Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create allPackageNames.st #644

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Create allPackageNames.st #644

merged 2 commits into from
Jun 12, 2024

Conversation

Ducasse
Copy link
Contributor

@Ducasse Ducasse commented Jun 11, 2024

RPackageOrganizer was deprecated in Pharo12 and removed in Pharo13

RPackageOrganizer was deprecated in Pharo12 and removed in Pharo13
@Ducasse
Copy link
Contributor Author

Ducasse commented Jun 11, 2024

@jecisc

@fniephaus
Copy link
Member

Thanks for the PR! Unfortunately, the Pharo64-13 check is failing with:

KeyNotFound: key #RPackageOrganizer not found in SystemDictionary
SystemDictionary(Dictionary)>>errorKeyNotFound:
[self errorKeyNotFound: key] in SystemDictionary(Dictionary)>>at: in Block: [self errorKeyNotFound: key]
SystemDictionary(Dictionary)>>at:ifAbsent:
SystemDictionary(Dictionary)>>at:
SmalltalkImage>>at:
SmalltalkCIPharo13 class(SmalltalkCIPharo class)>>packageNamed:ifAbsent:
SmalltalkCIPharo13 class(SmalltalkCIPharo class)>>classesInPackage:
[ :packageName | SmalltalkCI platformClass classesInPackage: packageName ] in [ :class | (self theNonMetaClassOf: class) packageNamesUnderTest
			gather: [ :packageName | SmalltalkCI platformClass classesInPackage: packageName ]] in SCIPharo12CodeCoverage(SCICodeCoverage)>>allPackagesUnderTestOf: in Block: [ :packageName | SmalltalkCI platformClass cla[..]
[ :each | stream nextPutAll: (aBlock value: each) ] in [ :stream | self do: [ :each | stream nextPutAll: (aBlock value: each) ] ] in Array(SequenceableCollection)>>flatCollect: in Block: [ :each | stream nextPutAll: (aBlock value: ea[..]
Array(SequenceableCollection)>>do:
[ :stream | self do: [ :each | stream nextPutAll: (aBlock value: each) ] ] in Array(SequenceableCollection)>>flatCollect: in Block: [ :stream | self do: [ :each | stream nextPutA[..]
Array class(SequenceableCollection class)>>new:streamContents:
Array(SequenceableCollection)>>flatCollect:
Array(Collection)>>gather:
[ :class | (self theNonMetaClassOf: class) packageNamesUnderTest
			gather: [ :packageName | SmalltalkCI platformClass classesInPackage: packageName ]] in SCIPharo12CodeCoverage(SCICodeCoverage)>>allPackagesUnderTestOf: in Block: [ :class | (self theNonMetaClassOf: class) pac[..]
[ :each | col addAll: (aBlock value: each) ] in Set(Collection)>>flatCollect:as: in Block: [ :each | col addAll: (aBlock value: each) ]
Set>>do:
Set(Collection)>>flatCollect:as:
Set(Collection)>>flatCollect:
Set(Collection)>>gather:
SCIPharo12CodeCoverage(SCICodeCoverage)>>allPackagesUnderTestOf:
SCIPharo12CodeCoverage(SCICodeCoverage)>>allClassesToCover
SCIPharo12CodeCoverage(SCIPharoCodeCoverage)>>allClassesToCover
SCIPharo12CodeCoverage(SCICodeCoverage)>>allMethodReferencesToCover
SCIPharo12CodeCoverage(SCICodeCoverage)>>startUp
SCIPharo12CodeCoverage(SCIPharoCodeCoverage)>>startUp
SCIPharo12CodeCoverage(SCICodeCoverage)>>run:
SCIPharo12CodeCoverage class(SCICodeCoverage class)>>run:spec:in:
[
			self prepareForTesting.
			self executionClass
				run: [ runner := self runTests ]
				spec: self spec
				in: self projectDirectory.
			self finishUpAfterTesting ] in SmalltalkCIPharo13(SmalltalkCI)>>basicTest in Block: [...
[ aBlock value ] in SmalltalkCIPharo13 class(SmalltalkCI class)>>fold:on:block: in Block: [ aBlock value ]

@theseion theseion requested a review from fniephaus June 11, 2024 18:43
@Ducasse
Copy link
Contributor Author

Ducasse commented Jun 11, 2024

Yes this is normal since the image used to run the tests is using the code that contains the error too.

@theseion theseion merged commit 25221dd into hpi-swa:master Jun 12, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants