[Bug]: GToolkit Download Target Should Include Zip Extension #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors like the following were happening because the folder was being passed to curl instead of the file: Starting GToolkit build... Downloading GToolkit64-release image... curl: (23) Failure writing output to destination curl failed to download https://github.com/feenkcom/gtoolkit/releases/download/v1.0.773/GlamorousToolkit-MacOS-aarch64-v1.0.773.zip to '~/Repositories/smalltalkCI/_cache/GlamorousToolkit-MacOS-aarch64-v1.0.773.zip'.
|
Since the GT check passed, and I only edited the GT script, I'm assuming the failing Pharo 3 check is unrelated. |
theseion
requested changes
May 16, 2024
Also, Do Not Reuse smalltalk_name Variable
theseion
requested changes
May 16, 2024
Co-authored-by: Max Leske <[email protected]>
Co-authored-by: Max Leske <[email protected]>
theseion
approved these changes
May 16, 2024
|
@fniephaus looks like some branch protection policy that prevents me from merging. 
|
Ok, I think I just gave you permission to merge PRs to master. Let me know if there's still any issue :) |
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors like the following were happening because the folder was being passed to curl instead of the file: Starting GToolkit build...
Downloading GToolkit64-release image...
curl: (23) Failure writing output to destination
curl failed to download https://github.com/feenkcom/gtoolkit/releases/download/v1.0.773/GlamorousToolkit-MacOS-aarch64-v1.0.773.zip to '~/Repositories/smalltalkCI/_cache/GlamorousToolkit-MacOS-aarch64-v1.0.773.zip'.