Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #listAtCategoryNamed: has been deprecated in Pharo 12 #606

Merged
merged 7 commits into from
Sep 26, 2023
Merged

fix: #listAtCategoryNamed: has been deprecated in Pharo 12 #606

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0f9ddae
fix: #listAtCategoryNamed: has been deprecated in Pharo 12
theseion Sep 23, 2023
7d23f15
fix: fix Pharo 12 deprecations in tests
theseion Sep 23, 2023
6592372
feat: make SCIMonticelloLoadSpecTest platform dependent
theseion Sep 24, 2023
e38fe6f
fix: remove "abstract" test, as test case is not abstract
theseion Sep 24, 2023
bf9266a
fix: update Pharo test
theseion Sep 24, 2023
9d366fc
feat: update Pharo VM and image urls
theseion Sep 24, 2023
78b6bd2
chore: update url tests for Pharo
theseion Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ry/SmalltalkCI-Core.package/SCIMonticelloLoadSpec.class/instance/addLoadedClassesFrom..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ addLoadedClassesFrom: aDefinitionsCollection
| mcOrganization classes |
mcOrganization := aDefinitionsCollection detect: [ :def | def isOrganizationDefinition ].
mcOrganization ifNil: [ self error: 'Could not find MCOrganizationDefinition' ].
classes := SmalltalkCI classesWithCategoryNames: mcOrganization categories.
self loadedClasses addAll: classes
classes := SmalltalkCI platformClass classesWithCategoryNames: mcOrganization categories.
self loadedClasses addAll: classes
6 changes: 6 additions & 0 deletions ...itory/SmalltalkCI-Pharo-Core.package/SmalltalkCIPharo12.class/class/classesInCategory..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
class organization
classesInCategory: aCategory
^ (Smalltalk organization tagForCategory: aCategory)
ifNotNil: [ :tag |
tag classNames collect: [ :className | Smalltalk at: className ] ]
ifNil: [ #() ]
12 changes: 10 additions & 2 deletions ...talkCI-Tests.package/SCIMonticelloLoadSpecTest.class/instance/testAddLoadedClassesFrom.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,16 @@ testAddLoadedClassesFrom
| mcOrganization |
self assert: true equals: (self spec loadedClasses isEmpty).

mcOrganization := MCOrganizationDefinition categories: #('SmalltalkCI-Core' 'SmalltalkCI-Tests').
mcOrganization := (MCOrganizationDefinition canUnderstand: #categories:)
ifTrue: [
"Squeak, Pharo < 12"
MCOrganizationDefinition categories: #('SmalltalkCI-Core' 'SmalltalkCI-Tests') ]
ifFalse: [
MCOrganizationDefinition
packageName: 'SmalltalkCI'
tagNames: #(Core Tests) ].

self spec addLoadedClassesFrom: {mcOrganization}.
self deny: (self spec loadedClasses isEmpty).
self assert: (self spec loadedClasses includes: SmalltalkCI).
self assert: (self spec loadedClasses includes: SmalltalkCITest).
self assert: (self spec loadedClasses includes: SmalltalkCITest).
Loading