Skip to content

Commit

Permalink
Squeak: Treat a test as failed when it raises a warning (#546)
Browse files Browse the repository at this point in the history
* Squeak: Treat a test as failed when it raises a warning

This realigns the SCI TestRunner again with the changed semantics in SUnit. See SUnit-ct.129 (Trunk):

	Catch warnings and halts in test case execution as well as Errors.

As a test which raises a warning now is displayed as red in the local TestRunner, smalltalkCI should adopt this behavior, too.

* Restore compatibility with <=Squeak5.3

* Update repository/SmalltalkCI-Squeak-Core.package/SCISqueakTestRunner.class/class/errorExceptions.st

Co-authored-by: Fabio Niephaus <[email protected]>
  • Loading branch information
LinqLover and fniephaus committed Jan 20, 2022
1 parent b30166b commit 9e3cda8
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
constants
errorExceptions

^ (TestResult respondsTo: #allErrors)
ifTrue: [ TestResult allErrors , TestResult failure ]
ifFalse: [ super errorExceptions "<= Squeak 5.3" ]
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"class" : {
},
"errorExceptions" : "ct 1/20/2022 00:09" },
"instance" : {
"stackTraceString:of:" : "fn 12/2/2016 11:41" } }
Loading

0 comments on commit 9e3cda8

Please sign in to comment.