Skip to content

Commit

Permalink
chore: ignore failures of GemStone64-3.5.3 on macOS
Browse files Browse the repository at this point in the history
  • Loading branch information
theseion committed May 7, 2024
1 parent 56afab5 commit 45aeced
Show file tree
Hide file tree
Showing 5 changed files with 46 additions and 45 deletions.
1 change: 1 addition & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ jobs:
smalltalk: GemStone64-3.6.0
- os: windows-2019
smalltalk: GemStone64-3.6.5
continue-on-error: ${{ startsWith(matrix.smalltalk, 'GemStone64') }}
runs-on: ${{ matrix.os }}
name: ${{ matrix.smalltalk }} on ${{ matrix.os }}
steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ baseline
setUpPharo5AndGreaterPackages: spec

spec
for: #(#'pharo5.x' #'pharo6.x' #'pharo7.x' #'pharo8.x' #'pharo9.x' #'pharo10.x' #'pharo11.x' #'pharo12.x', #'pharo13.x')
for: #(#'pharo5.x' #'pharo6.x' #'pharo7.x' #'pharo8.x' #'pharo9.x' #'pharo10.x' #'pharo11.x' #'pharo12.x' #'pharo13.x')
do: [ spec
package: 'SmalltalkCI-Core' with: [ spec includes: #('SmalltalkCI-Pharo-Core') ];
package: 'SmalltalkCI-Pharo-Core' with: [ spec requires: 'SmalltalkCI-Core' ];
Expand Down
Original file line number Diff line number Diff line change
@@ -1,31 +1,35 @@
fixtures
failureFixture

^ #( '#################################################'
'# Stdout-testReportFailure #'
'# 8 Tests with 4 Failures and 1 Errors in 0.01s #'
'#################################################'
^ #(
"The length of the separators and right padding depend on the time
the test suite took to execute, so we need to account for differences"
'#############################################*'
'# Stdout-testReportFailure *#'
'# 8 Tests with 4 Failures and 1 Errors in *s #'
'#############################################*'
'' '(3 tests passed)' '' 'SCIExcludedTests'
'[0m[32m ✓[0m #testDeprecation (0ms)[0m'
'[32m ✓[0m #testShouldFail (1ms)[0m'
'[32m ✓[0m #testShouldPass (0ms)[0m'
'[0m[32m ✓[0m #testDeprecation (*ms)[0m'
'[32m ✓[0m #testShouldFail (*ms)[0m'
'[32m ✓[0m #testShouldPass (*ms)[0m'
'#########################'
'# 5 tests did not pass: #'
'#########################'
'' ' ✗ #testAssertError (5ms)'
'TestFailure: Got 3 instead of 4.'
' ✗ #testError (1ms)'
'' ' ✗ #testAssertError (*ms)'
"Squeak and Pharo differ in the wording for the next line"
'TestFailure: * 3 * 4.'
' ✗ #testError (*ms)'
'Error: An error message.'
'[0m[1m[33m ✗ #testFailure (3ms)[0m'
'[0m[1m[33m ✗ #testFailure (*ms)[0m'
'TestFailure: A failure message.'
'[0m[1m[33m ✗ #testShouldPassUnexpectedly (0ms)[0m'
'[1mTestFailure: Test passed unexpectedly[0m[1m[33m ✗ #testThisIsAVeryLongMethodNameThat...playedCorrectlyInATravisLog (0ms)[0m'
'[0m[1m[33m ✗ #testShouldPassUnexpectedly (*ms)[0m'
'[1mTestFailure: Test passed unexpectedly[0m[1m[33m ✗ #testThisIsAVeryLongMethodNameThat...playedCorrectlyInATravisLog (*ms)[0m'
'TestFailure: Assertion failed'
'###########' '# Summary #'
'[1m[31m###########' '[0m[1m' '[0m[33m ✗ #testAssertError (5ms)[0m'
'[31m ✗ #testError (1ms)[0m' '[33m ✗ #testFailure (3ms)[0m'
'[33m ✗ #testShouldPassUnexpectedly (0ms)[0m'
'[33m ✗ #testThisIsAVeryLongMethodNameThatProbablyNeedsToBeContractedInOrderToBeDisplayedCorrectlyInATravisLog (0ms)[0m'
'[1m[31m###########' '[0m[1m' '[0m[33m ✗ #testAssertError (*ms)[0m'
'[31m ✗ #testError (*ms)[0m' '[33m ✗ #testFailure (*ms)[0m'
'[33m ✗ #testShouldPassUnexpectedly (*ms)[0m'
'[33m ✗ #testThisIsAVeryLongMethodNameThatProbablyNeedsToBeContractedInOrderToBeDisplayedCorrectlyInATravisLog (*ms)[0m'
'smalltalkCI Deprecation Warnings'
' - SCIExcludedTests>>testDeprecation (This is just a test)'
'[1m[31m Executed 8 Tests with 4 Failures and 1 Errors in 0.01s.[0m' )
'[1m[31m Executed 8 Tests with 4 Failures and 1 Errors in *s.[0m' )
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
fixtures
successFixture

^ #( '#################################################'
'# Stdout-testReportSuccess #'
'# 5 Tests with 0 Failures and 0 Errors in 0.01s #'
'#################################################'
^ #( "The length of the separators and right padding depend on the time
the test suite took to execute, so we need to account for differences"
'#############################################*'
'# Stdout-testReportSuccess *#'
'# 5 Tests with 0 Failures and 0 Errors in *s #'
'#############################################*'
'' '(5 tests passed)' '' 'SCIPassingTests'
'[0m[32m ✓[0m #testAssert (0ms)[0m'
'[32m ✓[0m #testAssertEquals (0ms)[0m'
'[32m ✓[0m #testDeny (0ms)[0m'
'[32m ✓[0m #testEmpty (0ms)[0m'
'[32m ✓[0m #testRaise (0ms)[0m'
'[1m[32m Executed 5 Tests with 0 Failures and 0 Errors in 0.01s.[0m' )
'[0m[32m ✓[0m #testAssert (*ms)[0m'
'[32m ✓[0m #testAssertEquals (*ms)[0m'
'[32m ✓[0m #testDeny (*ms)[0m'
'[32m ✓[0m #testEmpty (*ms)[0m'
'[32m ✓[0m #testRaise (*ms)[0m'
'[1m[32m Executed 5 Tests with 0 Failures and 0 Errors in *s.[0m' )
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,17 @@ helpers
assert: fixtures matches: aString
"Assert that all lines in the fixture are present. The actual output may
contain additional lines and the order may be different.
Note that we replace durations in both fixtures and input."
Note that the fixtures are patterns for #match:"

| cleanRegex cleanString cleanLines |
cleanRegex := ' [0-9]+\.[0-9]+s|\([0-9]+ms\)' asRegex.
cleanString := cleanRegex
copy: aString
replacingMatchesWith: '_duration_'.

cleanLines := cleanString lines asOrderedCollection.
| cleanLines |
cleanLines := aString lines asOrderedCollection.
fixtures do: [ :fixture |
| cleanFixture index |
cleanFixture := cleanRegex
copy: fixture
replacingMatchesWith: '_duration_'.
index := cleanLines indexOf: cleanFixture ifAbsent: [
| matchedLine |
matchedLine := cleanLines
detect: [ :line | fixture match: line ]
ifNone: [
TestResult failure signal:
'Cannot match: "' , cleanFixture , '" to: "'
, cleanString , '"' ].
'Cannot match: "' , fixture , '" to: "'
, aString , '"' ].
"We've seen this line, no need to look at it again"
cleanLines removeAt: index ]
cleanLines remove: matchedLine ]

0 comments on commit 45aeced

Please sign in to comment.