Skip to content

Commit

Permalink
Code cleanup up to SPBColumn
Browse files Browse the repository at this point in the history
  • Loading branch information
Antonia Heinen committed Jul 12, 2024
1 parent 1dff006 commit f77702c
Show file tree
Hide file tree
Showing 15 changed files with 33 additions and 28 deletions.
7 changes: 4 additions & 3 deletions Squello-Core.package/SPBBoard.class/instance/applyUserInterfaceTheme.st
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ initialize-release
applyUserInterfaceTheme

super applyUserInterfaceTheme.
addColumnColumn ifNotNil: [
addColumnColumn color: ((self userInterfaceTheme get: #color for: SystemWindow) ifNil: [Color lightGray]).
].
addColumnColumn
ifNotNil: [
addColumnColumn color: ((self userInterfaceTheme get: #color for: SystemWindow)
ifNil: [Color lightGray]).].
3 changes: 2 additions & 1 deletion Squello-Core.package/SPBBoard.class/instance/hasModelYellowButtonMenuItems.st
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
as yet unclassified
hasModelYellowButtonMenuItems
^ false

^ false.
3 changes: 1 addition & 2 deletions Squello-Core.package/SPBBoard.class/instance/saveBoard.st
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,4 @@ saveBoard
SPBLandingPage changeRecentGitHubBoards: {
#name -> self boardName.
#url -> self url.
#repo -> self boardProvider repo} asDictionary.
].
#repo -> self boardProvider repo} asDictionary.].
3 changes: 1 addition & 2 deletions Squello-Core.package/SPBBoard.class/instance/setUpChangeProvider.st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
initialize-release
setUpChangeProvider

self changeProvider projectId: self boardProvider projectId.
"self changeProvider api getWebhookChanges: self changeProvider webhookId."
self changeProvider projectId: self boardProvider projectId.
8 changes: 4 additions & 4 deletions Squello-Core.package/SPBBoard.class/methodProperties.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"activeCard" : "mcr 8/1/2022 02:31",
"addColumn" : "mcr 8/4/2022 00:40",
"addColumnLocal:" : "lo 8/3/2022 12:34",
"applyUserInterfaceTheme" : "AH 6/20/2024 16:20",
"applyUserInterfaceTheme" : "AH 7/12/2024 15:55",
"asJson" : "FP 7/4/2024 15:46",
"boardName" : "FP 6/25/2024 12:13",
"boardName:" : "FP 6/25/2024 12:13",
Expand Down Expand Up @@ -62,7 +62,7 @@
"errorCannotAddColumn:" : "jh 7/31/2022 14:28",
"errorInvalidUrl" : "mcr 8/2/2022 22:17",
"errorNoProjects" : "mcr 8/2/2022 22:15",
"hasModelYellowButtonMenuItems" : "L.L. 6/7/2024 22:59",
"hasModelYellowButtonMenuItems" : "AH 7/12/2024 15:56",
"indexOfColumn:" : "lo 8/3/2022 12:57",
"initialize" : "FP 6/10/2024 14:43",
"isLocal" : "FP 6/10/2024 15:01",
Expand All @@ -75,8 +75,8 @@
"removeColumn:" : "lo 8/1/2022 14:09",
"rerenderColumns" : "lo 7/31/2022 16:42",
"resizeColumnArea" : "jh 8/3/2022 01:07",
"saveBoard" : "FP 6/25/2024 14:06",
"setUpChangeProvider" : "Haru 5/13/2024 14:46",
"saveBoard" : "AH 7/12/2024 15:56",
"setUpChangeProvider" : "AH 7/12/2024 15:57",
"setupColumns" : "FP 6/17/2024 17:13",
"sidebar" : "mcr 8/1/2022 00:44",
"sidebar:" : "mcr 8/1/2022 00:44",
Expand Down
3 changes: 2 additions & 1 deletion Squello-Core.package/SPBBoardSaver.class/instance/boards.st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
accessing
boards

boards ifNil: [self boards: Dictionary new].
boards
ifNil: [self boards: Dictionary new].
^ boards.
3 changes: 2 additions & 1 deletion Squello-Core.package/SPBBoardSaver.class/instance/load..st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
save/load
load: anObject

^ self boards at: anObject ifAbsent: nil.
^ self boards at: anObject
ifAbsent: nil.
4 changes: 2 additions & 2 deletions Squello-Core.package/SPBBoardSaver.class/methodProperties.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
"class" : {
"defaultSaver" : "FP 6/3/2024 11:17" },
"instance" : {
"boards" : "FP 6/3/2024 11:15",
"boards" : "AH 7/12/2024 15:58",
"boards:" : "FP 6/3/2024 11:15",
"clear" : "FP 6/3/2024 11:15",
"contains:" : "FP 6/20/2024 17:14",
"delete:" : "FP 6/3/2024 11:15",
"load:" : "FP 6/25/2024 14:33",
"load:" : "AH 7/12/2024 15:58",
"save:as:" : "FP 6/3/2024 11:15" } }
2 changes: 1 addition & 1 deletion Squello-Core.package/SPBColumn.class/instance/cardPositions..st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
cardPositions: aCollection

cardPositions := aCollection
cardPositions := aCollection.
2 changes: 1 addition & 1 deletion Squello-Core.package/SPBColumn.class/instance/hash.st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
comparing
hash

"Answer an integer value that is related to the identity of the receiver."

^ self id hash.
3 changes: 2 additions & 1 deletion Squello-Core.package/SPBColumn.class/instance/isLastCard..st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
accessing
isLastCard: anSPBCard

self cards isEmpty ifTrue: [^ false].
self cards isEmpty
ifTrue: [^ false].
^ self cards last = anSPBCard.
2 changes: 1 addition & 1 deletion Squello-Core.package/SPBColumn.class/instance/jsonCards..st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
jsonCards: anObject

jsonCards := anObject
jsonCards := anObject.
3 changes: 2 additions & 1 deletion Squello-Core.package/SPBColumn.class/instance/minimumHeight.st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
geometry
minimumHeight

^ minimumHeight ifNil: [minimumHeight := self defaultMinimumHeight].
^ minimumHeight
ifNil: [minimumHeight := self defaultMinimumHeight].
3 changes: 2 additions & 1 deletion Squello-Core.package/SPBColumn.class/instance/pasteup.st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
accessing
pasteup

^ pasteup ifNil: [pasteup := SPBPluggablePasteUpMorph new].
^ pasteup
ifNil: [pasteup := SPBPluggablePasteUpMorph new.].
12 changes: 6 additions & 6 deletions Squello-Core.package/SPBColumn.class/methodProperties.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"cardDropped:Event:" : "jh 7/29/2022 12:57",
"cardFromId:" : "lo 8/3/2022 12:56",
"cardPositions" : "mcr 7/19/2022 19:44",
"cardPositions:" : "mcr 7/19/2022 19:36",
"cardPositions:" : "AH 7/12/2024 15:59",
"cards" : "mcr 7/14/2022 13:34",
"cards:" : "lo 5/26/2022 22:44",
"changeActiveCardTo:" : "NTK 7/30/2022 11:15",
Expand All @@ -41,7 +41,7 @@
"deleteCard:" : "jh 7/9/2022 18:05",
"fetchAndBuildSingleCard:" : "mcr 8/3/2022 23:17",
"getNextCardAfter:" : "mcr 8/4/2022 01:56",
"hash" : "LW 7/14/2022 11:12",
"hash" : "AH 7/12/2024 16:00",
"hideIndicator" : "NTK 7/30/2022 12:15",
"id" : "tkv 5/21/2022 00:59",
"id:" : "jh 6/3/2022 20:41",
Expand All @@ -50,14 +50,14 @@
"initializeBottomDetection" : "mcr 7/19/2022 13:18",
"initializeIndicator" : "lo 8/1/2022 12:27",
"isColumn" : "lo 8/1/2022 14:49",
"isLastCard:" : "FP 5/28/2024 12:01",
"isLastCard:" : "AH 7/12/2024 16:00",
"jsonCards" : "lo 6/8/2022 10:19",
"jsonCards:" : "LW 7/14/2022 11:12",
"minimumHeight" : "LW 7/14/2022 11:32",
"jsonCards:" : "AH 7/12/2024 16:00",
"minimumHeight" : "AH 7/12/2024 16:00",
"minimumHeight:" : "mcr 6/11/2022 15:51",
"moveColumn" : "tk 7/30/2022 21:58",
"moveIn:with:" : "mcr 8/4/2022 02:04",
"pasteup" : "mcr 7/19/2022 12:22",
"pasteup" : "AH 7/12/2024 16:01",
"pasteup:" : "jh 7/29/2022 12:58",
"removeFromOldColumn:" : "lo 8/3/2022 12:46",
"reorderCards:with:" : "NTK 8/3/2022 11:47",
Expand Down

0 comments on commit f77702c

Please sign in to comment.