Skip to content

Commit

Permalink
refactoring coding standarts
Browse files Browse the repository at this point in the history
  • Loading branch information
Haruko Schmidt committed Jul 12, 2024
1 parent 3b850fa commit 72f6a9d
Show file tree
Hide file tree
Showing 10 changed files with 26 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ initialization
applyUserInterfaceTheme

super applyUserInterfaceTheme.
self color: ((self userInterfaceTheme get: #uniformWindowColor for: Model) ifNil: [Color black]).
self color: ((self userInterfaceTheme get: #uniformWindowColor for: Model)
ifNil: [Color black]).
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
dropping/grabbing
repelsMorph: aMorph event: anEvent

^ self reject ifNotNil: [self reject value: aMorph value: anEvent].
^ self reject
ifNotNil: [self reject value: aMorph value: anEvent].
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"acceptDroppingMorph:event:" : "lo 8/1/2022 15:10",
"actionModel" : "lo 8/1/2022 15:17",
"actionModel:" : "lo 8/1/2022 15:18",
"applyUserInterfaceTheme" : "AH 6/14/2024 11:34",
"applyUserInterfaceTheme" : "Haru 7/12/2024 14:43",
"dropped" : "lo 5/26/2022 23:03",
"dropped:" : "lo 8/1/2022 15:10",
"handlesMouseOver:" : "tk 7/30/2022 22:27",
"initialize" : "AH 6/14/2024 11:21",
"isColumn" : "lo 8/1/2022 14:51",
"reject" : "lo 5/26/2022 21:43",
"reject:" : "lo 8/1/2022 15:11",
"repelsMorph:event:" : "LW 7/14/2022 11:27" } }
"repelsMorph:event:" : "Haru 7/12/2024 14:43" } }
3 changes: 2 additions & 1 deletion Squello-Core.package/SPBSidebar.class/instance/activeCard.st
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
accessing
activeCard

^ activeCard ifNil: [activeCard := SPBNullCard new].
^ activeCard
ifNil: [activeCard := SPBNullCard new].
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
accessing
getCloseButtonLabel

self activeCard isNote ifTrue: [^ 'Cannot close this card'].
self activeCard isClosed ifTrue: [^ 'Reopen'].
self activeCard isNote
ifTrue: [^ 'Cannot close this card'].
self activeCard isClosed
ifTrue: [^ 'Reopen'].
^ 'Close'.
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
accessing
potentialAssignees

^ potentialAssignees ifNil: [potentialAssignees := self boardProvider listPossibleAssignees].
^ potentialAssignees
ifNil: [potentialAssignees := self boardProvider listPossibleAssignees].
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ potentialAssigneesList
(self activeCard isRealCard not or: [potentialAssignees isNil])
ifTrue: [^ self potentialAssigneesListHeader].
^ self potentialAssigneesListHeader,
potentialAssignees select: [:potentialAssignee | (assignees includes: potentialAssignee) not].
potentialAssignees
select: [:potentialAssignee | (assignees includes: potentialAssignee) not].
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
accessing
potentialLabels

^ potentialLabels ifNil: [potentialLabels := self boardProvider listPossibleLabels].
^ potentialLabels
ifNil: [potentialLabels := self boardProvider listPossibleLabels].
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ potentialLabelsList
(self activeCard isRealCard not or: [potentialLabels isNil])
ifTrue: [^ self potentialLabelsListHeader].
^ self potentialLabelsListHeader,
potentialLabels select: [:potentialLabel | (labels includes: potentialLabel) not].
potentialLabels
select: [:potentialLabel | (labels includes: potentialLabel) not].
12 changes: 6 additions & 6 deletions Squello-Core.package/SPBSidebar.class/methodProperties.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"class" : {
},
"instance" : {
"activeCard" : "mcr 8/1/2022 01:18",
"activeCard" : "Haru 7/12/2024 14:31",
"activeCard:" : "AH 5/25/2024 17:28",
"activeCardAssigneeList" : "mcr 8/1/2022 00:50",
"activeCardAssigneeListHeader" : "mcr 8/1/2022 00:51",
Expand All @@ -24,23 +24,23 @@
"dropOnLabels:at:" : "lo 8/1/2022 14:55",
"dropOnPotentialAssignees:at:" : "lo 8/1/2022 14:55",
"dropOnPotentialLabels:at:" : "lo 8/1/2022 14:55",
"getCloseButtonLabel" : "AH 6/1/2024 17:59",
"getCloseButtonLabel" : "Haru 7/12/2024 14:28",
"labelIcon:" : "mcr 8/1/2022 01:15",
"labelSelected" : "mcr 8/1/2022 01:14",
"labelSelected:" : "lo 8/1/2022 14:55",
"onCloseButton" : "AH 5/25/2024 17:28",
"potentialAssigneeSelected" : "mcr 8/1/2022 01:13",
"potentialAssigneeSelected:" : "lo 8/1/2022 14:56",
"potentialAssignees" : "mcr 8/1/2022 01:16",
"potentialAssignees" : "Haru 7/12/2024 14:30",
"potentialAssignees:" : "mcr 8/1/2022 01:16",
"potentialAssigneesList" : "mcr 8/4/2022 02:16",
"potentialAssigneesList" : "Haru 7/12/2024 14:38",
"potentialAssigneesListHeader" : "mcr 8/1/2022 00:54",
"potentialLabelIcon:" : "mcr 8/1/2022 01:15",
"potentialLabelSelected" : "mcr 8/1/2022 01:14",
"potentialLabelSelected:" : "lo 8/1/2022 14:56",
"potentialLabels" : "mcr 8/1/2022 01:16",
"potentialLabels" : "Haru 7/12/2024 14:30",
"potentialLabels:" : "mcr 8/1/2022 01:17",
"potentialLabelsList" : "mcr 8/4/2022 02:29",
"potentialLabelsList" : "Haru 7/12/2024 14:39",
"potentialLabelsListHeader" : "mcr 8/1/2022 00:55",
"updateActiveCardDescription:" : "mcr 8/1/2022 01:12",
"updateActiveCardTitle:" : "mcr 8/1/2022 01:12",
Expand Down

0 comments on commit 72f6a9d

Please sign in to comment.