recent board buttons work now :)

hpi-swa-teaching · Jun 10, 2024 · 187301c · 187301c
1 parent b107d6c
commit 187301c
Show file tree

Hide file tree

Showing 10 changed files with 41 additions and 35 deletions.
diff --git a/Squello-Core.package/SPBBoard.class/class/open.st b/Squello-Core.package/SPBBoard.class/class/open.st
@@ -5,6 +5,4 @@ open
 	prompt := self promptUrl.
 	prompt = '' ifTrue: [^ self].
 	self lastProject: prompt.
-	(prompt beginsWith: self localPrefix) ifTrue: [^ self openLocal: prompt].
-	^ self newWith: prompt.
-
+	^ self openFromPrompt: prompt.
diff --git a/Squello-Core.package/SPBBoard.class/class/openFromPrompt..st b/Squello-Core.package/SPBBoard.class/class/openFromPrompt..st
@@ -0,0 +1,7 @@
+startup
+openFromPrompt: prompt
+
+	[(prompt beginsWith: self localPrefix) 
+		ifTrue: [self openLocal: prompt]
+		ifFalse: [self newWith: prompt.]] fork.
+
diff --git a/Squello-Core.package/SPBBoard.class/class/openInBackground.st b/Squello-Core.package/SPBBoard.class/class/openInBackground.st
diff --git a/Squello-Core.package/SPBBoard.class/methodProperties.json b/Squello-Core.package/SPBBoard.class/methodProperties.json
@@ -7,8 +7,8 @@
 		"localPrefix" : "FP 5/27/2024 17:40",
 		"newLocalWith:" : "FP 5/23/2024 09:43",
 		"newWith:" : "mcr 8/4/2022 01:09",
-		"open" : "FP 5/27/2024 17:40",
-		"openInBackground" : "FP 5/27/2024 15:33",
+		"open" : "FP 6/10/2024 16:24",
+		"openFromPrompt:" : "FP 6/10/2024 16:26",
 		"openLocal:" : "FP 6/8/2024 11:59",
 		"promptUrl" : "FP 5/23/2024 11:00",
 		"registerInAppsMenu" : "lo 6/4/2022 23:19" },

diff --git a/...age/SPBLandingPage.class/instance/buildRecentGitHubBoardsButtonSpecWith.withBoardInfo..st b/...age/SPBLandingPage.class/instance/buildRecentGitHubBoardsButtonSpecWith.withBoardInfo..st
@@ -1,3 +1,11 @@
-currently not in use
+toolbuilder
 buildRecentGitHubBoardsButtonSpecWith: aBuilder withBoardInfo: aDictionary
-
+
+	| name |
+	name := (aDictionary at: #repo), ' : ' ,( aDictionary at: #name).
+	^ aBuilder build: (aBuilder pluggableButtonSpec new
+		model: [SPBBoard openFromPrompt: (aDictionary at: #url)];
+		label: name;
+		action: #value;
+		yourself).
+
diff --git a/Squello-Core.package/SPBLandingPage.class/instance/buildRecentGitHubBoardsChildren.st b/Squello-Core.package/SPBLandingPage.class/instance/buildRecentGitHubBoardsChildren.st
@@ -0,0 +1,6 @@
+toolbuilder
+buildRecentGitHubBoardsChildren
+
+	|children|
+	children := ( self class RecentGitHubBoards collect: [:dictOfRecentBoard | self buildRecentGitHubBoardsButtonSpecWith: self usedBuilder withBoardInfo: dictOfRecentBoard] )asOrderedCollection.
+	^ children.
diff --git a/Squello-Core.package/SPBLandingPage.class/instance/buildRecentGitHubBoardsSpecWith..st b/Squello-Core.package/SPBLandingPage.class/instance/buildRecentGitHubBoardsSpecWith..st
@@ -1,16 +1,10 @@
 toolbuilder
 buildRecentGitHubBoardsSpecWith: aBuilder
 
-	| spec |
-	self usedBuilder: aBuilder.
-	spec := aBuilder pluggablePanelSpec new
-		model: self;
-		"label: 'Recent Local Boards';"
-
-		"frame: ([email protected] corner: 1@1);"
-		children: 
-			{"self class RecentGitHubBoards: [:recentGitHubBoard | self buildRecentGitHubBoardsButtonSpecWith: aBuilder withBoardInfo: recentGitHubBoard] 
-		"};
-		layout: #horizontal;
-		yourself.
-	^ aBuilder build: spec.
+	^ aBuilder pluggablePanelSpec new
+			name: #RecentGitHubBoards;
+			model: self;
+			children: #buildRecentGitHubBoardsChildren;
+			layout: #horizontal;
+			yourself.
+
diff --git a/...e.package/SPBLandingPage.class/instance/buildRecentLocalBoardsButtonSpecWith.withName..st b/...e.package/SPBLandingPage.class/instance/buildRecentLocalBoardsButtonSpecWith.withName..st
@@ -3,7 +3,8 @@ buildRecentLocalBoardsButtonSpecWith: aBuilder withName: aName
 
 
 	^ aBuilder build: (aBuilder pluggableButtonSpec new
-		model: self;
+		model: [SPBBoard openFromPrompt: aName];
+		action: #value;
 		label: aName;
 		yourself).
 
diff --git a/Squello-Core.package/SPBLandingPage.class/instance/buildRecentLocalBoardsChildren.st b/Squello-Core.package/SPBLandingPage.class/instance/buildRecentLocalBoardsChildren.st
@@ -3,9 +3,4 @@ buildRecentLocalBoardsChildren
 
 	|children|
 	children := ( self class RecentLocalBoards collect: [:NameOfRecentLocalBoard | self buildRecentLocalBoardsButtonSpecWith: self usedBuilder withName: NameOfRecentLocalBoard] )asOrderedCollection.
-	^ children.
-	 "pluggableButtonSpec new
-		model: self;
-		label: 
-		yourself."
-
+	^ children.
diff --git a/Squello-Core.package/SPBLandingPage.class/methodProperties.json b/Squello-Core.package/SPBLandingPage.class/methodProperties.json
@@ -16,10 +16,11 @@
 		"buildNewLocalBoardSpecWith:" : "Haru 6/7/2024 12:14",
 		"buildOpenBoardSpecWith:" : "Haru 6/7/2024 12:14",
 		"buildRecentBoardsSpecWith:" : "FP 6/10/2024 15:28",
-		"buildRecentGitHubBoardsButtonSpecWith:withBoardInfo:" : "Haru 6/9/2024 13:57",
-		"buildRecentGitHubBoardsSpecWith:" : "Haru 6/9/2024 19:55",
-		"buildRecentLocalBoardsButtonSpecWith:withName:" : "FP 6/10/2024 14:09",
-		"buildRecentLocalBoardsChildren" : "FP 6/10/2024 14:06",
+		"buildRecentGitHubBoardsButtonSpecWith:withBoardInfo:" : "FP 6/10/2024 16:27",
+		"buildRecentGitHubBoardsChildren" : "FP 6/10/2024 16:00",
+		"buildRecentGitHubBoardsSpecWith:" : "FP 6/10/2024 15:55",
+		"buildRecentLocalBoardsButtonSpecWith:withName:" : "FP 6/10/2024 16:27",
+		"buildRecentLocalBoardsChildren" : "FP 6/10/2024 15:59",
 		"buildRecentLocalBoardsSpecWith:" : "FP 6/10/2024 14:20",
 		"buildResetUserAccountSpecWith:" : "Haru 6/7/2024 12:15",
 		"buildSidebarSpecWith:" : "FP 6/10/2024 14:36",