semantics plugin: rename classvar Plugins -> Instances, add cleanUp

hpi-swa-lab · Aug 27, 2023 · 5d6466c · 5d6466c
1 parent e62b870
commit 5d6466c
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 11 deletions.
diff --git a/...alkExtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/class/cleanUp..st b/...alkExtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/class/cleanUp..st
@@ -0,0 +1,5 @@
+initialize-release
+cleanUp: aggressive
+
+	aggressive = true ifTrue:
+		[Instances := nil].
diff --git a/...boxTalkExtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/class/for..st b/...boxTalkExtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/class/for..st
@@ -1,5 +1,5 @@
 accessing
 for: aConversationBrowser
 
-	^ self plugins at: aConversationBrowser ifAbsentPut:
+	^ self instances at: aConversationBrowser ifAbsentPut:
 		[self newFor: aConversationBrowser]
diff --git a/...lkExtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/class/instances.st b/...lkExtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/class/instances.st
@@ -0,0 +1,7 @@
+accessing
+instances
+
+	^ Instances ifNil:
+		[Instances := WeakKeyDictionary new.
+		WeakArray addWeakDependent: Instances.
+		Instances]
diff --git a/...TalkExtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/class/plugins.st b/...TalkExtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/class/plugins.st
diff --git a/...xtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/methodProperties.json b/...xtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/methodProperties.json
@@ -1,8 +1,9 @@
 {
 	"class" : {
-		"for:" : "ct 8/21/2023 02:15",
+		"cleanUp:" : "ct 8/27/2023 20:54",
+		"for:" : "ct 8/27/2023 20:50",
+		"instances" : "ct 8/27/2023 20:49",
 		"newFor:" : "ct 8/21/2023 02:15",
-		"plugins" : "ct 8/26/2023 00:09",
 		"semanticConversationConfig" : "ct 8/21/2023 02:27",
 		"shouldIncludeSimilarConversations" : "ct 8/21/2023 03:06",
 		"shouldIncludeSmartSummary" : "ct 8/26/2023 02:39",

diff --git a/...xTalkExtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/properties.json b/...xTalkExtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/properties.json
@@ -4,7 +4,7 @@
 		 ],
 	"classvars" : [
 		"ConversationConfig",
-		"Plugins",
+		"Instances",
 		"ShouldIncludeSmartSummary" ],
 	"commentStamp" : "ct 8/26/2023 01:11",
 	"instvars" : [