semantics: fix weak ref error in plugin due to closed browser

hpi-swa-lab · Aug 29, 2023 · 285a16e · 285a16e
1 parent 47040c4
commit 285a16e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/...s-Semantics.package/TalkSemanticConversationBrowserPlugin.class/instance/changed.with..st b/...s-Semantics.package/TalkSemanticConversationBrowserPlugin.class/instance/changed.with..st
@@ -2,8 +2,9 @@ updating
 changed: aspect with: anObject
 
 	aspect = #insertTextReplacement ifTrue:
-		[self browser selectedSpecialMessage ifNotNil: [:specialMessage |
-			anObject first = specialMessage second "textSelector" ifTrue:
-				[self browser changed: aspect with: (anObject copy at: 1 put: #currentText; yourself)]]].
+		[self browser ifNotNil: [:actualBrowser |
+			actualBrowser selectedSpecialMessage ifNotNil: [:specialMessage |
+				anObject first = specialMessage second "textSelector" ifTrue:
+					[actualBrowser changed: aspect with: (anObject copy at: 1 put: #currentText; yourself)]]]].
 
 	super changed: aspect with: anObject.
diff --git a/...xtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/methodProperties.json b/...xtras-Semantics.package/TalkSemanticConversationBrowserPlugin.class/methodProperties.json
@@ -15,7 +15,7 @@
 		"aspectDependencies" : "ct 8/21/2023 03:09",
 		"browser" : "ct 8/25/2023 23:55",
 		"cancelSmartSummary" : "ct 8/21/2023 02:34",
-		"changed:with:" : "ct 8/21/2023 02:53",
+		"changed:with:" : "ct 8/27/2023 23:57",
 		"conversation" : "ct 8/21/2023 02:26",
 		"initializeForBrowser:" : "ct 8/27/2023 22:04",
 		"requestSimilarConversations" : "ct 8/27/2023 21:59",