Bugfix/#162/prevent protoui value duplication #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work, thank you! |
JulianEgbert
deleted the
bugfix/#162/prevent-protoui-value-duplication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes from #155b5f4 and #32140b4 the prototyping ui will not display duplicate Value- or CodeBehaviors.
Instead, it will display a little +1,+2,+3... counter next to the variable name for ValueBehaviors.
For CodeBehaviors this counter was deemed unnecessary but can easily be added to the code at a later point in time.
The code introduced for this issue can surely still be improved as for now the handling is done based on child types and counts within the prototyping ui.
Let me know if any changes are required before merging.