-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC4J-651 JirabotMerge: Allow multiple projects to be configured #762
Conversation
Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-651 Jirabot Action Result: |
sys.exit(1) | ||
|
||
project_list_regex = '|'.join(project_prefixes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming PROJECT_CONFIG can now be comprised of multiple project names delimited by '|' ? It might be worth explicitly defining the newly supported syntax somewhere.
Also, perhaps outside the scope of this change but the Errors regarding PROJECT_CONFIG could be more informative about what PROJECT_CONFIG is (github action variable)
.github/workflows/JirabotMerge.yml
Outdated
if project_name is None: | ||
print('Error: PROJECT_CONFIG is missing required field: projectName') | ||
project_prefixes = projectConfig.get('projectPrefixes') | ||
if project_prefixes is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to protect against empty projectPrefixes value?, not sure if this "None" test is only testing null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpmcmu approved
- Modified script to allow multiple projects to be controlled from a single script - Fixed regex warning on escaped characters Signed-off-by: James McMullan [email protected]
Jirabot Action Result: |
Signed-off-by: James McMullan [email protected]
Type of change:
Checklist:
Testing: