-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC4J-553 Github Actions: Add baremetal test workflow #669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpmcmu seems fine, left a few comments/questions
fetch-depth: 0 | ||
|
||
- name: Rebase | ||
if: github.event_name == 'pull_request' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does github provide a mechanism to save and re-use jobs? If so, it feels like we should reuse some of these
|
||
branch_name = os.environ['BRANCH_NAME'] | ||
latestVersion = getLatestBranchVersion(branch_name) | ||
latestVersionURL = 'https://cdn.hpccsystems.com/releases/CE-Candidate-' + latestVersion + '/bin/platform/hpccsystems-platform-community_' + latestVersion + '-1jammy_amd64_withsymbols.deb' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll have to communicate this dependency to Clo, just so they know to let us know before they plan to move away from this cdn, etc.
latestVersion = getLatestBranchVersion(branch_name) | ||
latestVersionURL = 'https://cdn.hpccsystems.com/releases/CE-Candidate-' + latestVersion + '/bin/platform/hpccsystems-platform-community_' + latestVersion + '-1jammy_amd64_withsymbols.deb' | ||
|
||
# Return latest version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover commented out code?
- Renamed existing k8s workflow - Added baremetal workflow Signed-off-by: James McMullan [email protected]
@rpastrana Fixed the git tag issue and addressed code review comments. Please review |
branch_name = os.environ['BRANCH_NAME'] | ||
|
||
latestVersion = getLatestBranchVersion(branch_name) | ||
previousVersion = [latestVersion[0], latestVersion[1], latestVersion[2] - 2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should report failure if point==0 and cannot be found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpmcmu one comment
Signed-off-by: James McMullan [email protected]
Type of change:
Checklist:
Testing: