Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC4J-545 Resume read test causes OOM error #651

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Oct 26, 2023

  • Updated resume read to use a smaller read buffer size

Signed-off-by: James McMullan [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@jpmcmu
Copy link
Contributor Author

jpmcmu commented Oct 26, 2023

@rpastrana I tested out various scenarios and to check if the prefetch thread wasn't exiting and retaining a copy of the read buffer, but in my testing the prefetch thread was exiting as expected. I also looked into moving the read buffer to a ByteBuffer to see if using a directly allocated buffer would speed up GC, but that didn't work either. End solution was just to decrease the read buffer size for the failing test.

Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu approve

@rpastrana rpastrana changed the base branch from candidate-9.4.x to candidate-9.2.x October 26, 2023 14:38
- Updated resume read to use a smaller read buffer size

Signed-off-by: James McMullan [email protected]
@rpastrana rpastrana merged commit 1059053 into hpcc-systems:candidate-9.2.x Oct 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants