Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-537 Log open / close operation info #637

Merged
merged 1 commit into from
Sep 6, 2023
Merged

HPCC4J-537 Log open / close operation info #637

merged 1 commit into from
Sep 6, 2023

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Aug 29, 2023

  • Added open / close logging output

Signed-off-by: James McMullan [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@github-actions
Copy link

https://track.hpccsystems.com//browse/JAPI-537
Failed to set to merge pending: transitions=[]Jira updated

@jpmcmu
Copy link
Contributor Author

jpmcmu commented Aug 29, 2023

@rpastrana please review

rpastrana
rpastrana reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu looks fine, one question about reporting the rec definition every time.
Also, this should be accompanied by a wiki entry.

dfsclient/src/main/java/org/hpccsystems/dfs/client/HPCCRemoteFileWriter.java
log.info("HPCCRemoteFileWriter: Opening file part: " + dataPartition.getThisPart()
+ " compression: " + fileCompression.name() + " "
+ " record definition:\n"
+ RecordDefinitionTranslator.toJsonRecord(this.recordDef));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the bloat factor of this output?
Was there discussion of reserving this output for error/warning situations only?

@github-actions
Copy link

https://track.hpccsystems.com//browse/JAPI-537
This pull request is already registered

@jpmcmu jpmcmu closed this Aug 30, 2023
@jpmcmu jpmcmu reopened this Aug 30, 2023
@github-actions
Copy link

https://track.hpccsystems.com//browse/JAPI-537
This pull request is already registered

@jpmcmu
HPCC4J-537 Log open / close operation info
e33add2 
- Added open / close logging output

Signed-off-by: James McMullan [email protected]
rpastrana
rpastrana approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu approved. Please add link to wiki entry.

@jpmcmu
Copy link
Contributor Author

jpmcmu commented Sep 6, 2023

@rpastrana Added the logging information under the publish failure entry as we had discussed: https://github.com/hpcc-systems/hpcc4j/wiki/Common-Issues-and-Solutions#publish-failed-due-to-missing-file-parts

@jpmcmu jpmcmu changed the base branch from master to candidate-9.2.x September 6, 2023 14:16
@rpastrana rpastrana merged commit 6c3da4f into hpcc-systems:candidate-9.2.x Sep 6, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpastrana rpastrana rpastrana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcmu @rpastrana