Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to move window by one finger after multifinger long press triggerd? #156

Closed
L-Trump opened this issue Sep 9, 2024 · 5 comments · Fixed by #157
Closed

Comments

@L-Trump
Copy link

L-Trump commented Sep 9, 2024

Longpress to move/resize window is really a fancy enhancement provided by hyprgrass. But in recent use I found that it's easy to break a touch by moving multiple fingers at the same time. Is it possible to longpress by multi-fingers and then only use one finger to perform the bindm operation?

@horriblename
Copy link
Owner

try #157

I'll test and merge next month after my vacation

@L-Trump
Copy link
Author

L-Trump commented Sep 12, 2024

Thanks for your work! Two tests failed during building:

  ==== stdout:
drag started: longpress:3
cancel touch on windows
drag update
drag update
gesture cancelled
drag update
===============================================================================
../src/gestures/test/test.cpp:234:
TEST CASE:  Long press and drag: full drag

../src/gestures/test/test.cpp:93: ERROR: CHECK( gm.dragEnded ) is NOT correct!
  values: CHECK( false )

  ==== stdout:
gesture cancelled
  ==== stdout:
gesture cancelled
  ==== stdout:
drag started: edge:l:r
gesture triggered: edge:l:r
  ==== stdout:
drag started: edge:l:r
===============================================================================
../src/gestures/test/test.cpp:297:
TEST CASE:  Edge Swipe: Timeout during swiping phase

../src/gestures/test/test.cpp:97: ERROR: CHECK( gm.cancelled ) is NOT correct!
  values: CHECK( false )

Allowed to fail so marking it as not failed
  ==== stdout:
  ==== stdout:
drag started: edge:l:r
cancel touch on windows
drag update
  ==== stdout:
gesture cancelled
  ==== stdout:
gesture cancelled
  ==== stdout:
drag started: edge:l:r
gesture triggered: edge:l:r
  ==== stdout:
drag started: edge:l:r
===============================================================================

@horriblename
Copy link
Owner

fixd

@L-Trump
Copy link
Author

L-Trump commented Sep 13, 2024

Successfully built. But the move/resize actions don't finish after lifting all fingers up.

2024-09-13.12-51-33.mp4

@horriblename
Copy link
Owner

fuck I thought it would be a 5 line change

I'll pick this back up at a later time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants