Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back forgery protection with Rails internals #136

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

hopsoft
Copy link
Owner

@hopsoft hopsoft commented May 21, 2024

Re-introduces CSRF protection using Rails internal mechanics.

Opt-in to forgery protection like so.

TurboBoost::Commands.config.protect_from_forgery = true

Resolves #36
Resolves #132

Copy link

github-actions bot commented May 21, 2024

AppMap runtime code review

Summary Status
Failed tests ✅ All tests passed
Security flaws ✅ None detected
Performance problems ✅ None detected
Code anti-patterns ✅ None detected
New AppMaps 0️⃣ No new AppMaps

Warnings occurred during analysis:

(apiDiff) Error comparing OpenAPI definitions: Validation errors in "base": Swagger schema validation failed. 
  Data does not match any schemas from 'oneOf' at #/paths//tests/get/responses/285
    Missing required property: description at #/paths//tests/get/responses/285
    Missing required property: $ref at #/paths//tests/get/responses/285
 
JSON_OBJECT_VALIDATION_FAILED

@hopsoft hopsoft merged commit 9eb6f4f into main May 21, 2024
10 checks passed
@hopsoft hopsoft deleted the hopsoft/forgery branch May 21, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to use native Rails CSRF for Command POST Using reflex produces error with validatng server token
1 participant