Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Debian 11 Bullseye #5335

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ikifar2012
Copy link
Member

@ikifar2012 ikifar2012 commented Oct 9, 2024

Proposed change

I think now is the time to drop support for Debian Bullseye, I held off because of the privilege issues we were having in the past but I have not seen any issues pop up recently in regards to that and in my own testing it seems it has been solved by home-assistant/version#370, #4381 and home-assistant/version#372. Thus I am now comfortable with dropping Debian 11 Bullseye

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints or add-on configuration are added/changed:

Summary by CodeRabbit

  • New Features

    • Updated the supported operating systems list to include only "Debian GNU/Linux 12 (bookworm)."
  • Bug Fixes

    • Enhanced evaluation logic to ensure only supported operating systems are recognized, improving system compatibility checks.

Copy link

coderabbitai bot commented Oct 9, 2024

📝 Walkthrough

Walkthrough

The changes involve an update to the SUPPORTED_OS constant in the operating_system.py file, where the entry for "Debian GNU/Linux 11 (bullseye)" has been removed. This adjustment modifies the evaluation logic within the EvaluateOperatingSystem class, specifically the evaluate method, which now only recognizes "Debian GNU/Linux 12 (bookworm)" as a supported operating system.

Changes

File Path Change Summary
supervisor/resolution/evaluations/operating_system.py Updated SUPPORTED_OS constant by removing "Debian GNU/Linux 11 (bullseye)", retaining only "Debian GNU/Linux 12 (bookworm)". Adjusted evaluation logic in EvaluateOperatingSystem.evaluate method accordingly.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
supervisor/resolution/evaluations/operating_system.py (1)

Line range hint 33-36: Consider updating documentation and user messages

The change to SUPPORTED_OS will cause the evaluate method to flag any OS other than Debian 12 (bookworm) as unsupported. While this is consistent with the PR objectives, it's important to ensure that:

  1. Any relevant documentation is updated to reflect this change in supported operating systems.
  2. User-facing messages (like the one in the on_failure property) clearly communicate that only Debian 12 is now supported.

This will help prevent confusion for users who may still be using Debian 11 or other operating systems.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 1ee01b1 and 98c7951.

📒 Files selected for processing (1)
  • supervisor/resolution/evaluations/operating_system.py (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
supervisor/resolution/evaluations/operating_system.py (1)

8-8: LGTM: Change aligns with PR objectives

The modification to SUPPORTED_OS correctly implements the PR objective to drop support for Debian 11 Bullseye. This change is straightforward and aligns well with the provided PR summary.

@agners agners merged commit e2b25fe into home-assistant:main Oct 9, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants