Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Entity to EntityState #378

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/commands.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import { Connection } from "./connection.js";
import * as messages from "./messages.js";
import {
HassEntity,
HassEntityState,
HassServices,
HassConfig,
HassUser,
HassServiceTarget,
} from "./types.js";

export const getStates = (connection: Connection) =>
connection.sendMessagePromise<HassEntity[]>(messages.states());
connection.sendMessagePromise<HassEntityState[]>(messages.states());

export const getServices = (connection: Connection) =>
connection.sendMessagePromise<HassServices>(messages.services());
Expand Down
2 changes: 1 addition & 1 deletion lib/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export * from "./collection.js";
export * from "./connection.js";
export * from "./config.js";
export * from "./services.js";
export * from "./entities.js";
export * from "./states.js";
export * from "./errors.js";
export * from "./socket.js";
export * from "./types.js";
Expand Down
46 changes: 28 additions & 18 deletions lib/entities.ts → lib/states.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { getCollection } from "./collection.js";
import {
Context,
HassEntities,
HassEntityStates,
StateChangedEvent,
UnsubscribeFunc,
} from "./types.js";
Expand Down Expand Up @@ -44,7 +44,7 @@ interface StatesUpdates {
c: Record<string, EntityDiff>;
}

function processEvent(store: Store<HassEntities>, updates: StatesUpdates) {
function processEvent(store: Store<HassEntityStates>, updates: StatesUpdates) {
const state = { ...store.state };

if (updates.a) {
Expand Down Expand Up @@ -127,13 +127,13 @@ function processEvent(store: Store<HassEntities>, updates: StatesUpdates) {
store.setState(state, true);
}

const subscribeUpdates = (conn: Connection, store: Store<HassEntities>) =>
const subscribeUpdates = (conn: Connection, store: Store<HassEntityStates>) =>
conn.subscribeMessage<StatesUpdates>((ev) => processEvent(store, ev), {
type: "subscribe_entities",
});

function legacyProcessEvent(
store: Store<HassEntities>,
store: Store<HassEntityStates>,
event: StateChangedEvent
) {
const state = store.state;
Expand All @@ -143,34 +143,44 @@ function legacyProcessEvent(
if (new_state) {
store.setState({ [new_state.entity_id]: new_state });
} else {
const newEntities = { ...state };
delete newEntities[entity_id];
store.setState(newEntities, true);
const newStates = { ...state };
delete newStates[entity_id];
store.setState(newStates, true);
}
}

async function legacyFetchEntities(conn: Connection): Promise<HassEntities> {
async function legacyFetchEntityStates(
conn: Connection
): Promise<HassEntityStates> {
const states = await getStates(conn);
const entities: HassEntities = {};
const entityStates: HassEntityStates = {};
for (let i = 0; i < states.length; i++) {
const state = states[i];
entities[state.entity_id] = state;
entityStates[state.entity_id] = state;
}
return entities;
return entityStates;
}

const legacySubscribeUpdates = (conn: Connection, store: Store<HassEntities>) =>
const legacySubscribeUpdates = (
conn: Connection,
store: Store<HassEntityStates>
) =>
conn.subscribeEvents<StateChangedEvent>(
(ev) => legacyProcessEvent(store, ev as StateChangedEvent),
"state_changed"
);

export const entitiesColl = (conn: Connection) =>
export const entityStatesColl = (conn: Connection) =>
atLeastHaVersion(conn.haVersion, 2022, 4, 0)
? getCollection(conn, "_ent", undefined, subscribeUpdates)
: getCollection(conn, "_ent", legacyFetchEntities, legacySubscribeUpdates);

export const subscribeEntities = (
: getCollection(
conn,
"_ent",
legacyFetchEntityStates,
legacySubscribeUpdates
);

export const subscribeEntityStates = (
conn: Connection,
onChange: (state: HassEntities) => void
): UnsubscribeFunc => entitiesColl(conn).subscribe(onChange);
onChange: (state: HassEntityStates) => void
): UnsubscribeFunc => entityStatesColl(conn).subscribe(onChange);
14 changes: 7 additions & 7 deletions lib/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ export type StateChangedEvent = HassEventBase & {
event_type: "state_changed";
data: {
entity_id: string;
new_state: HassEntity | null;
old_state: HassEntity | null;
new_state: HassEntityState | null;
old_state: HassEntityState | null;
};
};

Expand Down Expand Up @@ -67,16 +67,16 @@ export type HassConfig = {
language: string;
};

export type HassEntityBase = {
export type HassEntityStateBase = {
entity_id: string;
state: string;
last_changed: string;
last_updated: string;
attributes: HassEntityAttributeBase;
attributes: HassEntityStateAttributeBase;
context: Context;
};

export type HassEntityAttributeBase = {
export type HassEntityStateAttributeBase = {
friendly_name?: string;
unit_of_measurement?: string;
icon?: string;
Expand All @@ -89,11 +89,11 @@ export type HassEntityAttributeBase = {
restored?: boolean;
};

export type HassEntity = HassEntityBase & {
export type HassEntityState = HassEntityStateBase & {
attributes: { [key: string]: any };
};

export type HassEntities = { [entity_id: string]: HassEntity };
export type HassEntityStates = { [entity_id: string]: HassEntityState };

export type HassService = {
name?: string;
Expand Down
10 changes: 5 additions & 5 deletions test/entities.spec.ts → test/states.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as assert from "assert";

import { subscribeEntities } from "../dist/entities";
import { subscribeEntityStates } from "../dist/states";
import { MockConnection, AwaitableEvent } from "./util";

const MOCK_LIGHT = {
Expand Down Expand Up @@ -28,7 +28,7 @@ describe("subscribeEntities legacy", () => {

it("should load initial entities", async () => {
awaitableEvent.prime();
subscribeEntities(conn, awaitableEvent.set);
subscribeEntityStates(conn, awaitableEvent.set);

const entities = await awaitableEvent.wait();
assert.deepStrictEqual(entities, {
Expand All @@ -38,7 +38,7 @@ describe("subscribeEntities legacy", () => {
});

it("should handle state changed with updated state", async () => {
subscribeEntities(conn, awaitableEvent.set);
subscribeEntityStates(conn, awaitableEvent.set);

await 0;
await 0;
Expand Down Expand Up @@ -68,7 +68,7 @@ describe("subscribeEntities legacy", () => {
});

it("should handle state changed with new state", async () => {
subscribeEntities(conn, awaitableEvent.set);
subscribeEntityStates(conn, awaitableEvent.set);

await 0;
await 0;
Expand Down Expand Up @@ -99,7 +99,7 @@ describe("subscribeEntities legacy", () => {
});

it("should handle state changed with removed state", async () => {
subscribeEntities(conn, awaitableEvent.set);
subscribeEntityStates(conn, awaitableEvent.set);

await 0;
await 0;
Expand Down