-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aiofiles to package constraints #127749
Conversation
Please run the gen_requirements_all script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding a new constraint, couldn't we just add the custom integration to the block list here?
Lines 92 to 94 in 4721f8e
BLOCKED_CUSTOM_INTEGRATIONS: dict[str, BlockedIntegration] = { | |
# Added in 2024.3.0 because of https://github.com/home-assistant/core/issues/112464 | |
"start_time": BlockedIntegration(AwesomeVersion("1.1.7"), "breaks Home Assistant"), |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
It doesn't crash or cause any performance issues atm. I don't think it's right to take out the bazooka for this one. |
But isn't the result similar? With either method the custom integration will fail to install. Either because of the check for blocked integrations or because the requirements don't match our constraints. Better to have a good error message then. |
I'm going to close this one, since I don't think it appropriate to block a custom integration at this moment. |
Proposed change
Some (popular) custom integration https://github.com/UI-Lovelace-Minimalist/UI pinned aiofiles to 0.8.0, which has no support for python 3.12. Adding this library to package constraints as a temporary workaround. See #126904 for more information. There are 8 core integrations that rely on this library.
PR at the custom integration: UI-Lovelace-Minimalist/UI#1543
Type of change
Additional information
AttributeError: '_io.TextIOWrapper' object has no attribute 'delete'
#126904Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: