Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust polling rate of Rituals Perfume Genie #127544

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Adjust polling rate of Rituals Perfume Genie #127544

merged 1 commit into from
Oct 4, 2024

Conversation

frenck
Copy link
Member

@frenck frenck commented Oct 4, 2024

Proposed change

This changes the polling rate of the Rituals Perfume Genie integration.
The API is now limited to 30 polling requests per hour for all the devices combined.

To avoid hitting those limits:

  • Adjusted the default polling rate to be every 3 minutes (20 calls per hour); giving a little breathing room for restarts as well.
  • The polling rate is multiplied by the number of diffusers one has to avoid hitting the limits.

This adjustment isn't perfect, but it should be OK for most use cases. For a future goal, a different API should be used; but until that is in place, this will take away almost all problems people have.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Oct 4, 2024

Hey there @milanmeu, mind taking a look at this pull request as it has been labeled with an integration (rituals_perfume_genie) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rituals_perfume_genie can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign rituals_perfume_genie Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@frenck frenck marked this pull request as ready for review October 4, 2024 09:18
@frenck frenck added this to the 2024.10.1 milestone Oct 4, 2024
@frenck frenck merged commit f1b6ae8 into dev Oct 4, 2024
31 checks passed
@frenck frenck deleted the frenck-2024-0527 branch October 4, 2024 09:21
@frenck frenck mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rituals genie stopped working
2 participants