Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow smlight device to reboot before updating firmware data coordinator #127442

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

tl-sl
Copy link
Contributor

@tl-sl tl-sl commented Oct 3, 2024

Breaking change

Proposed change

Seems there is a race condition between data coordinator update and SLZB-06 device reboot. If update occurs before reboot it will return old version and makes it look like update didn't complete. Add a small delay to allow SLZB-06 device time to reboot before coordinator update.

Can we pick this bug fix for next stable release.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes # 127422
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@tl-sl tl-sl changed the title Add small delay before updating firmware data coordinator Allow device to reboot before updating firmware data coordinator Oct 4, 2024
@MartinHjelmare MartinHjelmare changed the title Allow device to reboot before updating firmware data coordinator Allow smlight device to reboot before updating firmware data coordinator Oct 4, 2024
@tl-sl tl-sl requested a review from frenck October 4, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants