Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AIS tracker integration #123956

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Aug 14, 2024

Proposed change

With this HA can receive AIS messages via udp socket (eq. from an own ais-catcher instance), which enables one to track vessels. Later this integration will be extended to also support fetching ais messages from a server via an tcp connection, which will allow to connect to public AIS instances.

TODO:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck
Copy link
Member

frenck commented Sep 27, 2024

@mib1185 Any reason this is still in draft?

@mib1185
Copy link
Contributor Author

mib1185 commented Sep 27, 2024

just did not find the time to complete this, yet 🙈 still need to write docs and tbh i'm not really happy with the current implementation of the ais_listener within the coordinator, since it wraps a sync udp socket listener in a async background task 🙁 maybe this is actually ok, but just my gut feeling tells me it's not a good solution 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants