Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bimmer_connected to 0.15.3 #118179

Merged
merged 3 commits into from
May 27, 2024

Conversation

rikroe
Copy link
Contributor

@rikroe rikroe commented May 26, 2024

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @gerard33, mind taking a look at this pull request as it has been labeled with an integration (bmw_connected_drive) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of bmw_connected_drive can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign bmw_connected_drive Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mib1185
Copy link
Contributor

mib1185 commented May 26, 2024

@coderabbitai review and please also summarise the changes if the new library

Copy link

coderabbitai bot commented May 26, 2024

Tip

For best results, initiate chat on the files or code changes.

@mib1185, here's a summary of the changes in the new library version bimmer_connected 0.15.3:

What’s Changed

  1. Update timezone handling for time only data (#617): This update, contributed by @rikroe, addresses the handling of timezone information for data that only includes time, ensuring better accuracy and compatibility.
  2. Use assignment expressions (PEP572) (#615): Also contributed by @rikroe, this change incorporates Python's assignment expressions (PEP 572), which can make certain parts of the code clearer and more concise.

These updates are part of the ongoing improvements to enhance the functionality and reliability of the library.

If you need further details or have specific aspects of the PR you'd like reviewed, please let me know!

Analysis chain
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Fetch the release notes for bimmer_connected 0.15.3
curl -s https://github.com/bimmerconnected/bimmer_connected/releases/tag/0.15.3

Length of output: 161166

@rikroe
Copy link
Contributor Author

rikroe commented May 26, 2024

Test fails due to unrelated package (FAILED tests/components/teslemetry/test_diagnostics.py::test_diagnostics - AssertionError: assert [+ received] == [- snapshot]).

@mib1185
Copy link
Contributor

mib1185 commented May 26, 2024

there are two different components failing:

FAILED tests/components/teslemetry/test_diagnostics.py::test_diagnostics - AssertionError: assert [+ received] == [- snapshot]
    ......
        ...
            'vehicle_state_software_update_install_perc': 1,
  -         'vehicle_state_software_update_status': 'available',
  +         'vehicle_state_software_update_status': 'installing',
            'vehicle_state_software_update_version': '2024.12.0.0',
        ...
    })
ERROR tests/components/homekit/test_homekit.py::test_reload - BaseExceptionGroup: errors while tearing down <Coroutine test_reload> (2 sub-exceptions)

will do a fast cross check

@mib1185
Copy link
Contributor

mib1185 commented May 26, 2024

ok, they are not failing local

Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @rikroe :+1

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 26, 2024 18:54
Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong button 🤦

@mib1185 mib1185 marked this pull request as ready for review May 26, 2024 18:57
@home-assistant home-assistant bot requested a review from mib1185 May 26, 2024 18:57
@home-assistant home-assistant bot marked this pull request as draft May 26, 2024 20:56
@rikroe rikroe marked this pull request as ready for review May 26, 2024 22:08
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rikroe 👍

../Frenck

@frenck frenck merged commit 10291b1 into home-assistant:dev May 27, 2024
38 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect/missing timezons for charging_times Unable to update charging_profile warning since 2024.5.0
4 participants