-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZHA support for Bosch Twinguard and siren install QR codes #107460
Add ZHA support for Bosch Twinguard and siren install QR codes #107460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
6327c3c
to
ec34a86
Compare
There are ruff errors here. if you run the setup script at the bottom of this page: https://developers.home-assistant.io/docs/development_environment you will get a pre-commit hook that will prevent lint errors from making it to CI. |
Thx for the hint. I was running locally |
be2196f
to
f2ecbe5
Compare
e273abb
to
c6fff6c
Compare
These devices contain inside their QR code device specific link keys instead of installation codes. Normally, the link key is generated from the installation code, but in this case we can directly pass the provided link key from QR code to zigpy application controller.
Convert installation code directly to link key
e98df27
to
07c0cd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
These devices contain inside their QR code device specific link keys instead of installation codes. Normally, the link key is generated from the installation code, but in this case we can directly pass the provided link key from QR code to zigpy application controller.
Proposed change
Resolves feature request to support Bosch Twinguard devices via ZHA zigpy/zha-device-handlers#2561
Type of change
Additional information
Bosch Twinguard and Bosch Outdoor Siren supplies device specific link key instead of installation code within their QR codes.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: