Add entity translations to iBeacon (#95460)

* Add entity translations to iBeacon * Add entity translations to iBeacon
home-assistant · Jun 28, 2023 · ecfb259 · ecfb259
1 parent 4959fce
commit ecfb259
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 11 deletions.
diff --git a/homeassistant/components/ibeacon/sensor.py b/homeassistant/components/ibeacon/sensor.py
@@ -38,7 +38,6 @@ class IBeaconSensorEntityDescription(SensorEntityDescription, IBeaconRequiredKey
 SENSOR_DESCRIPTIONS = (
     IBeaconSensorEntityDescription(
         key="rssi",
-        name="Signal Strength",
         device_class=SensorDeviceClass.SIGNAL_STRENGTH,
         native_unit_of_measurement=SIGNAL_STRENGTH_DECIBELS_MILLIWATT,
         entity_registry_enabled_default=False,
@@ -47,7 +46,7 @@ class IBeaconSensorEntityDescription(SensorEntityDescription, IBeaconRequiredKey
     ),
     IBeaconSensorEntityDescription(
         key="power",
-        name="Power",
+        translation_key="power",
         device_class=SensorDeviceClass.SIGNAL_STRENGTH,
         native_unit_of_measurement=SIGNAL_STRENGTH_DECIBELS_MILLIWATT,
         entity_registry_enabled_default=False,
@@ -56,7 +55,7 @@ class IBeaconSensorEntityDescription(SensorEntityDescription, IBeaconRequiredKey
     ),
     IBeaconSensorEntityDescription(
         key="estimated_distance",
-        name="Estimated Distance",
+        translation_key="estimated_distance",
         icon="mdi:signal-distance-variant",
         native_unit_of_measurement=UnitOfLength.METERS,
         value_fn=lambda ibeacon_advertisement: ibeacon_advertisement.distance,
@@ -65,7 +64,7 @@ class IBeaconSensorEntityDescription(SensorEntityDescription, IBeaconRequiredKey
     ),
     IBeaconSensorEntityDescription(
         key="vendor",
-        name="Vendor",
+        translation_key="vendor",
         entity_registry_enabled_default=False,
         value_fn=lambda ibeacon_advertisement: ibeacon_advertisement.vendor,
     ),

diff --git a/homeassistant/components/ibeacon/strings.json b/homeassistant/components/ibeacon/strings.json
@@ -19,5 +19,18 @@
         }
       }
     }
+  },
+  "entity": {
+    "sensor": {
+      "power": {
+        "name": "Power"
+      },
+      "estimated_distance": {
+        "name": "Estimated distance"
+      },
+      "vendor": {
+        "name": "Vendor"
+      }
+    }
   }
 }
diff --git a/tests/components/ibeacon/test_sensor.py b/tests/components/ibeacon/test_sensor.py
@@ -56,7 +56,7 @@ async def test_sensors_updates_fixed_mac_address(hass: HomeAssistant) -> None:
     assert distance_sensor.state == "2"
     assert (
         distance_attributes[ATTR_FRIENDLY_NAME]
-        == "BlueCharm_177999 8105 Estimated Distance"
+        == "BlueCharm_177999 8105 Estimated distance"
     )
     assert distance_attributes[ATTR_UNIT_OF_MEASUREMENT] == "m"
     assert distance_attributes[ATTR_STATE_CLASS] == "measurement"
@@ -70,7 +70,7 @@ async def test_sensors_updates_fixed_mac_address(hass: HomeAssistant) -> None:
     assert distance_sensor.state == "0"
     assert (
         distance_attributes[ATTR_FRIENDLY_NAME]
-        == "BlueCharm_177999 8105 Estimated Distance"
+        == "BlueCharm_177999 8105 Estimated distance"
     )
     assert distance_attributes[ATTR_UNIT_OF_MEASUREMENT] == "m"
     assert distance_attributes[ATTR_STATE_CLASS] == "measurement"
@@ -97,7 +97,7 @@ async def test_sensors_updates_fixed_mac_address(hass: HomeAssistant) -> None:
     assert distance_sensor.state == "14"
     assert (
         distance_attributes[ATTR_FRIENDLY_NAME]
-        == "BlueCharm_177999 8105 Estimated Distance"
+        == "BlueCharm_177999 8105 Estimated distance"
     )
     assert distance_attributes[ATTR_UNIT_OF_MEASUREMENT] == "m"
     assert distance_attributes[ATTR_STATE_CLASS] == "measurement"
@@ -204,7 +204,7 @@ async def test_multiple_uuids_same_beacon(hass: HomeAssistant) -> None:
     distance_attributes = distance_sensor.attributes
     assert distance_sensor.state == "400"
     assert (
-        distance_attributes[ATTR_FRIENDLY_NAME] == "FSC-BP108 EEFF Estimated Distance"
+        distance_attributes[ATTR_FRIENDLY_NAME] == "FSC-BP108 EEFF Estimated distance"
     )
     assert distance_attributes[ATTR_UNIT_OF_MEASUREMENT] == "m"
     assert distance_attributes[ATTR_STATE_CLASS] == "measurement"
@@ -217,7 +217,7 @@ async def test_multiple_uuids_same_beacon(hass: HomeAssistant) -> None:
     distance_attributes = distance_sensor.attributes
     assert distance_sensor.state == "0"
     assert (
-        distance_attributes[ATTR_FRIENDLY_NAME] == "FSC-BP108 EEFF Estimated Distance"
+        distance_attributes[ATTR_FRIENDLY_NAME] == "FSC-BP108 EEFF Estimated distance"
     )
     assert distance_attributes[ATTR_UNIT_OF_MEASUREMENT] == "m"
     assert distance_attributes[ATTR_STATE_CLASS] == "measurement"
@@ -230,7 +230,7 @@ async def test_multiple_uuids_same_beacon(hass: HomeAssistant) -> None:
     distance_attributes = distance_sensor.attributes
     assert distance_sensor.state == "400"
     assert (
-        distance_attributes[ATTR_FRIENDLY_NAME] == "FSC-BP108 EEFF Estimated Distance"
+        distance_attributes[ATTR_FRIENDLY_NAME] == "FSC-BP108 EEFF Estimated distance"
     )
     assert distance_attributes[ATTR_UNIT_OF_MEASUREMENT] == "m"
     assert distance_attributes[ATTR_STATE_CLASS] == "measurement"
@@ -239,7 +239,7 @@ async def test_multiple_uuids_same_beacon(hass: HomeAssistant) -> None:
     distance_attributes = distance_sensor.attributes
     assert distance_sensor.state == "0"
     assert (
-        distance_attributes[ATTR_FRIENDLY_NAME] == "FSC-BP108 EEFF Estimated Distance"
+        distance_attributes[ATTR_FRIENDLY_NAME] == "FSC-BP108 EEFF Estimated distance"
     )
     assert distance_attributes[ATTR_UNIT_OF_MEASUREMENT] == "m"
     assert distance_attributes[ATTR_STATE_CLASS] == "measurement"