Skip to content

Commit

Permalink
Adjust message
Browse files Browse the repository at this point in the history
  • Loading branch information
@epenet
epenet committed Oct 4, 2024
1 parent 07e2fa2 commit 08e0d09
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions homeassistant/config_entries.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2715,9 +2715,9 @@ def async_create_entry( # type: ignore[override]
)
_LOGGER.warning(
(
"Detected %s config flow using `async_create_entry`, which "
"can cause unexpected behavior and will stop working in %s. "
"Please %s"
"Detected %s config flow creating a new entry, "
"when it is expected to update an existing entry and abort. "
"This will stop working in %s, please %s"
),
self.source,
"2025.11",
Expand Down
6 changes: 3 additions & 3 deletions tests/test_config_entries.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6752,9 +6752,9 @@ async def _async_step_confirm(self):
assert len(entries) == 2

assert (

Check failure on line 6754 in tests/test_config_entries.py

View workflow job for this annotation

GitHub Actions / Run tests Python 3.12 (9) 

test_create_entry_reauth_reconfigure[reauth-unique-unique]

AssertionError: assert 'Detected reauth config flow creating a new entry, when it is expected to update an existing entry. This will stop wor...a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+test%22' in '2024-10-04 11:11:56.232 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:56.235 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n'
 +  where '2024-10-04 11:11:56.232 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:56.235 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n' = <_pytest.logging.LogCaptureFixture object at 0x7f80b84a9df0>.text

Check failure on line 6754 in tests/test_config_entries.py

View workflow job for this annotation

GitHub Actions / Run tests Python 3.12 (9) 

test_create_entry_reauth_reconfigure[reauth-unique-new]

AssertionError: assert 'Detected reauth config flow creating a new entry, when it is expected to update an existing entry. This will stop wor...a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+test%22' in '2024-10-04 11:11:56.555 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:56.558 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n'
 +  where '2024-10-04 11:11:56.555 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:56.558 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n' = <_pytest.logging.LogCaptureFixture object at 0x7f80b8211af0>.text

Check failure on line 6754 in tests/test_config_entries.py

View workflow job for this annotation

GitHub Actions / Run tests Python 3.12 (9) 

test_create_entry_reauth_reconfigure[reauth-unique-None]

AssertionError: assert 'Detected reauth config flow creating a new entry, when it is expected to update an existing entry. This will stop wor...a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+test%22' in '2024-10-04 11:11:56.759 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:56.762 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n'
 +  where '2024-10-04 11:11:56.759 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:56.762 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n' = <_pytest.logging.LogCaptureFixture object at 0x7f80b8202660>.text

Check failure on line 6754 in tests/test_config_entries.py

View workflow job for this annotation

GitHub Actions / Run tests Python 3.12 (9) 

test_create_entry_reauth_reconfigure[reauth-None-unique]

AssertionError: assert 'Detected reauth config flow creating a new entry, when it is expected to update an existing entry. This will stop wor...a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+test%22' in '2024-10-04 11:11:56.962 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:56.965 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n'
 +  where '2024-10-04 11:11:56.962 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:56.965 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n' = <_pytest.logging.LogCaptureFixture object at 0x7f80b834b3e0>.text

Check failure on line 6754 in tests/test_config_entries.py

View workflow job for this annotation

GitHub Actions / Run tests Python 3.12 (9) 

test_create_entry_reauth_reconfigure[reconfigure-unique-unique]

AssertionError: assert 'Detected reconfigure config flow creating a new entry, when it is expected to update an existing entry. This will sto...a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+test%22' in '2024-10-04 11:11:57.177 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:57.180 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n'
 +  where '2024-10-04 11:11:57.177 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:57.180 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n' = <_pytest.logging.LogCaptureFixture object at 0x7f80b83482c0>.text

Check failure on line 6754 in tests/test_config_entries.py

View workflow job for this annotation

GitHub Actions / Run tests Python 3.12 (9) 

test_create_entry_reauth_reconfigure[reconfigure-unique-new]

AssertionError: assert 'Detected reconfigure config flow creating a new entry, when it is expected to update an existing entry. This will sto...a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+test%22' in '2024-10-04 11:11:57.377 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:57.380 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n'
 +  where '2024-10-04 11:11:57.377 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:57.380 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n' = <_pytest.logging.LogCaptureFixture object at 0x7f80b8200b60>.text

Check failure on line 6754 in tests/test_config_entries.py

View workflow job for this annotation

GitHub Actions / Run tests Python 3.12 (9) 

test_create_entry_reauth_reconfigure[reconfigure-unique-None]

AssertionError: assert 'Detected reconfigure config flow creating a new entry, when it is expected to update an existing entry. This will sto...a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+test%22' in '2024-10-04 11:11:57.583 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:57.586 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n'
 +  where '2024-10-04 11:11:57.583 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:57.586 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n' = <_pytest.logging.LogCaptureFixture object at 0x7f80b846a5a0>.text

Check failure on line 6754 in tests/test_config_entries.py

View workflow job for this annotation

GitHub Actions / Run tests Python 3.12 (9) 

test_create_entry_reauth_reconfigure[reconfigure-None-unique]

AssertionError: assert 'Detected reconfigure config flow creating a new entry, when it is expected to update an existing entry. This will sto...a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+test%22' in '2024-10-04 11:11:57.786 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:57.789 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n'
 +  where '2024-10-04 11:11:57.786 INFO     MainThread homeassistant.loader:loader.py:784 Loaded test from homeassistant.compone...integration%3A+test%22\n2024-10-04 11:11:57.789 INFO     MainThread homeassistant.setup:setup.py:384 Setting up test\n' = <_pytest.logging.LogCaptureFixture object at 0x7f80b8469b80>.text
f"Detected {source} config flow using `async_create_entry`, "
"which can cause unexpected behavior and will stop working in "
"2025.11. Please create a bug report at https://github.com/home"
f"Detected {source} config flow creating a new entry, when it is expected "
"to update an existing entry. This will stop working in "
"2025.11, please create a bug report at https://github.com/home"
"-assistant/core/issues?q=is%3Aopen+is%3Aissue+"
"label%3A%22integration%3A+test%22"
) in caplog.text

0 comments on commit 08e0d09

Please sign in to comment.