Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark style icon, logo files for custom integration zyxel_snmp #5800

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Lhb-tw
Copy link
Contributor

@Lhb-tw Lhb-tw commented Aug 26, 2024

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/Lhb-tw/zyxel_snmp

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @Lhb-tw 👋

I could not find the public repository providing this custom integration. Can you please point me to it?

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 10, 2024 11:54
@Lhb-tw
Copy link
Contributor Author

Lhb-tw commented Sep 10, 2024

Hi there @Lhb-tw 👋

I could not find the public repository providing this custom integration. Can you please point me to it?

../Frenck

Dear Frenck!

Good day!
Thank you for the response!
Due to I'm not a software engineer with coding background, lack of coding experience, I found my current custom integration version exists performance issue thus previously switched to private repository..

Now I switch back to public again.
The performance problem no that much time to check thus still under tuning... hope this will not impact the custom logo upload

Thank you for checking.

BR,

Lhb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants