-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dask tiles regression #1432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1432 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.01%
==========================================
Files 52 52
Lines 7751 7775 +24
==========================================
+ Hits 6894 6915 +21
- Misses 857 860 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we recommend to users that have a dask dataset with lat/lon coordinates?
Good question, you should still be able to make it project by explicitly requesting it. |
Co-authored-by: Simon Høxbro Hansen <[email protected]>
Same behavior from <0.11 releases; manually setting
|
But that still requires GeoViews? If so, maybe there's a way to special case |
Closes #1431