Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ahuang11 committed Jun 17, 2024
1 parent 787e2de commit c4c1c75
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions hvplot/ui.py
Original file line number Diff line number Diff line change
Expand Up @@ -675,9 +675,9 @@ def _plot(self):
xmax = np.max(np.abs(self.xlim()))
self.geographic.crs = 'PlateCarree' if xmax <= 360 else 'GOOGLE_MERCATOR'
kwargs['crs'] = self.geographic.crs
if 'projection' not in kwargs:
kwargs['projection'] = kwargs['crs']
for key in ['crs', 'projection']:
if key not in kwargs:
continue
crs_kwargs = kwargs.pop(f'{key}_kwargs', {})
kwargs[key] = instantiate_crs_str(kwargs.pop(key), **crs_kwargs)
feature_scale = kwargs.pop('feature_scale', None)
Expand Down Expand Up @@ -708,7 +708,6 @@ def _plot(self):
self._alert.param.update(
object=f'**Rendering failed with following error**: {e}', visible=True
)
raise e
finally:
self._layout.loading = False

Expand Down

0 comments on commit c4c1c75

Please sign in to comment.