Refactor of CUDA *_n reductions #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
+ Coverage 83.49% 83.62% +0.12%
==========================================
Files 35 35
Lines 8955 8938 -17
==========================================
- Hits 7477 7474 -3
+ Misses 1478 1464 -14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #1260, refactoring CUDA
*_nreductions to reduce code duplication and make the GPU code more similar to the CPU code. It adds a newcuda_shift_and_insertfunction, separates out the 3D and 4D*_ncombine functions, and adds*_implfunctions for the shared functionality between the 3D and 4D combinations.