Fix maximum wages of 9,999,999.99 being invalid (#42)

hmrc · May 28, 2020 · 8869d9c · 8869d9c
1 parent 023f64c
commit 8869d9c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/commonMain/kotlin/uk/gov/hmrc/calculator/utils/validation/WageValidator.kt b/src/commonMain/kotlin/uk/gov/hmrc/calculator/utils/validation/WageValidator.kt
@@ -25,5 +25,5 @@ object WageValidator {
 
     fun isAboveMinimumWages(wages: Double) = wages > 0
 
-    fun isBelowMaximumWages(wages: Double) = wages < 9999999.99
+    fun isBelowMaximumWages(wages: Double) = wages <= 9999999.99
 }
diff --git a/src/commonTest/kotlin/uk/gov/hmrc/calculator/utils/validation/WageValidatorTests.kt b/src/commonTest/kotlin/uk/gov/hmrc/calculator/utils/validation/WageValidatorTests.kt
@@ -51,10 +51,20 @@ class WageValidatorTests {
     }
 
     @Test
-    fun `Validate wages below max`() {
+    fun `Validate wages below max no decimal`() {
         assertTrue(WageValidator.isBelowMaximumWages(9999999.0))
     }
 
+    @Test
+    fun `Validate wages below max with decimal`() {
+        assertTrue(WageValidator.isBelowMaximumWages(9999999.99))
+    }
+
+    @Test
+    fun `Validate wages below max with decimal but 3 places`() {
+        assertFalse(WageValidator.isBelowMaximumWages(9999999.991))
+    }
+
     @Test
     fun `Validate wages above max`() {
         assertFalse(WageValidator.isBelowMaximumWages(10000000.0))