-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add urls and views #20
base: draft-16-master
Are you sure you want to change the base?
Conversation
Swap simplejson out for stdlib json in the testsites api test
Some sort of strangeness here - github won't let me automatically merge this. Kind of makes me nervous, but I don't immediately understand why, unless it's because there are commits that have already been made in the pul request? |
IMO, Github auto-merges should only be used on documentation changes, not for logic/functionality changes. |
Upon review, this should be merged in. I don't have rights, but it looks very solid to me. |
Sorry guys, I've been offline during hte week, I'll go ahead and do a request without the duplicate commits. |
Apologies here too, I've had a pretty busy half-week or so. |
This should be merged in, why hasn't this been merged in yet ? |
As you can see in the comments, I was left expecting an updated request without duplicate commits, and so dropped it. |
The patch also removes simplejson as a dependency, and while I can sympathize with that goal, it has a few effects that I'm not sure I can support -
|
Adding oauth2app a views module and pluggable url patterns.
Updated the example project to use those.