edit DNS grammar #3768

Checconio · 2023-04-26T20:10:44Z

add support for character strings and modification of DNS registration type recognition

Changes

add
{
// Character strings
scope: 'string',
begin: '"', end: '"'
},
{
className: 'type',
begin: /IN|CH/
}

edit KEYWORDS

Checklist

[ X] Added markup tests, or they don't apply here because...
[ X] Updated the changelog at CHANGES.md

joshgoebel · 2023-04-27T02:35:11Z

Please show us an example of this syntax in an actual DNS file. Any how did we decide IN and CH are types?

Checconio · 2023-04-27T08:23:17Z

Hello,

The current syntax detects comments in values that are strings, which is a bug.

Here is the overview of the current syntax

In my syntax I add support for character strings to fix the comment bug in DNS values

In the current file, the keywords are the DNS record names, which is not the case for the "IN" and "CH" values which correspond to the class of the DNS record.
That's why I wanted to separate them.

Here is the result of my changes

src/languages/dns.js

joshgoebel · 2023-04-28T01:51:48Z

src/languages/dns.js

      {
        className: 'meta',
        begin: /^\$(TTL|GENERATE|INCLUDE|ORIGIN)\b/
      },
+      {
+        className: 'type',


joshgoebel · 2023-04-28T01:51:55Z

src/languages/dns.js

      {
        className: 'meta',
        begin: /^\$(TTL|GENERATE|INCLUDE|ORIGIN)\b/
      },
+      {
+        className: 'type',
+        begin: /IN|CH/


joshgoebel · 2023-04-28T01:55:55Z

In my syntax I add support for character strings to fix the comment bug in DNS values

Yep. Nice. If you wanted to push further why not highlight everything following TXT as a string, quoted or not? This would prevent the other false positives we are seeing of random highlighting inside those strings.

In the current file, the keywords are the DNS record names, which is not the case for the "IN" and "CH" values which correspond to the class of the DNS record.

Makes sense.

Scoping () as punctuation might be nice as well.

joshgoebel

A few suggestions/changes above.

Checconio · 2023-04-28T10:43:43Z

I made the corrections and we now have a file that looks good :)

joshgoebel · 2023-04-29T15:54:56Z

Please provide your test content here in textual form.

Checconio · 2023-04-30T10:44:23Z

Please provide your test content here in textual form.

;
; BIND data file for local loopback interface
;
$TTL    3600
$ORIGIN checconio.fr.
$INCLUDE "Kchecconio.fr.zsk.key"
$INCLUDE "Kchecconio.fr.ksk.key"

@       IN      SOA     server.dorianchecconi.fr. root.dorianchecconi.fr. (
                        2023040124      ; Serial
                        1200            ; Refresh
                        120             ; Retry
                        604800          ; Expire
                        3600 )  ; Negative Cache TTL

@               IN      NS      server.dorianchecconi.fr.

@               IN      CAA     0       issue   "letsencrypt.org"

@               IN      MX      10      server.dorianchecconi.fr.

@               IN      TXT     google-site-verification=aU4dDNsp6XuXfh2-3cTTU4
@               IN      TXT     brave-ledger-verification=807e569d632d84c67b73c1847321ce63c6f35be9a1ca
@               IN      TXT     "v=spf1 a mx ip4:80.31.156.3 ~all"
_dmarc          IN      TXT     "v=DMARC1;p=reject;pct=100;ruf=mailto:[email protected];rua=mailto:[email protected];sp=reject;adkim=s;aspf=s;rf=afrf;fo=1"
_domainkey      IN      TXT     "o=-; [email protected]"
mail._domainkey IN      TXT     ( "v=DKIM1; h=sha256; k=rsa; ""p=MIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICoeVFwlbm1MB3ax4vQTB9Sk0llRKIuWxuidRG/h74PdwNf3iSyA9UxeRZPR0qZOChSoWvXQKGAyWmwrRQQoqmzUTp9xaHPra6+ds+quSvzWLZBLI3iulGu1X6QcehfTNfsnJkCLIxnxh""sm8AME8WzmxVL48xQSx6BhrOh6iz1U9EEPB0+5q5aV0iY0VvzJsm0fcTZ9GtVGoJCzcVORZgedY5R7WYeVkEDecX8teAiFNZihigwfdN3XemBwcl2U+eGmUgqeeHSJaJ36ooKnnUq7zB+w4dHWmJYo7yN5VdPeDVyTE/KwB+PoRCNfhe2/VGfSso0jsi+azp5bBfj6EFYxcyDtaLeoDUjK+v/qqPH76MUjcvA9/P7J4UxoNZcaP3laszB9""G/s/krbY7em3qjKrdW4IAqlaEAb6H4KskR1W0rBz4RdjOmP6XsoygL2Z2Q7uglT4lpEJYWk12FuV7k3F0AiXtKdlMduCb2wQGsOlh2ZE4oaEqRvwJEPvZyI8wyEF3QN27buYbX6GnMC+X8x1TfzcUTnKxzZX2Q0X5b2JVaLEvmd+VipcA6FtLSfR8AFikzB9X/9EJxHYm4vc48kOLhhGlVsLbzw5Ygz09ScCAwEAAQ==" )
_smtp._tls              IN      TXT     "v=TLSRPTv1;rua=mailto:[email protected]"

;_autodiscover._tcp     IN      SRV     10      10      443 autodiscover.checconio.fr.

@               IN      A       80.31.156.3
autodiscover    IN      A       82.11.196.30

Checconio · 2023-05-07T08:40:12Z

test content

The test content is good ?

Checconio · 2023-05-24T16:53:10Z

joshgoebel Have you news for this change ?

Thank's

joshgoebel · 2023-05-25T04:46:19Z

Please pull down my latest commit and test. It tries to more accurately handle TXT records. You might have to -f since I rebased. If it looks good and you could make sure the tests are back in sync then I think this is good to ship.

Checconio

Add

Checconio · 2023-05-26T10:24:55Z

Please pull down my latest commit and test. It tries to more accurately handle TXT records. You might have to -f since I rebased. If it looks good and you could make sure the tests are back in sync then I think this is good to ship.

Thank you for these modifications I have just tested and confirm that everything is good!

Checconio · 2023-06-23T11:41:06Z

joshgoebel It's good for you ?

…n type recognition

joshgoebel · 2024-10-31T22:45:39Z

@ IN TXT google-site-verification=aU4dDNsp6XuXfh2;notgoodbob

What is the ; here? Part of the string or a comment, do you know?

github-actions · 2024-10-31T22:49:39Z

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 files changed

Total change +267 B

View Changes

file	base	pr	diff
es/core.min.js	8.18 KB	8.18 KB	+1 B
es/highlight.min.js	8.18 KB	8.18 KB	+1 B
es/languages/dns.min.js	635 B	767 B	+132 B
languages/dns.min.js	639 B	772 B	+133 B

github-actions · 2024-10-31T22:57:42Z

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change +196 B

View Changes

file	base	pr	diff
es/languages/dns.min.js	635 B	733 B	+98 B
highlight.min.js	8.22 KB	8.22 KB	-1 B
languages/dns.min.js	639 B	738 B	+99 B

joshgoebel · 2024-10-31T22:58:49Z

Also wonder if we should highlight issue and issuewild (the tags for CAA) as something?

joshgoebel reviewed Apr 28, 2023

View reviewed changes

src/languages/dns.js Outdated Show resolved Hide resolved

joshgoebel reviewed Apr 28, 2023

View reviewed changes

joshgoebel requested changes Apr 28, 2023

View reviewed changes

joshgoebel force-pushed the dns branch from 04e9df0 to 4be1346 Compare May 25, 2023 04:44

Checconio requested a review from joshgoebel May 26, 2023 09:59

Checconio commented May 26, 2023

View reviewed changes

joshgoebel force-pushed the main branch from 59ac021 to 2a4acf4 Compare October 9, 2023 03:56

add support for character strings and modification of DNS registratio…

5a0de3e

…n type recognition

Checconio and others added 3 commits October 31, 2024 18:48

Update CHANGES.md

d9f03c0

fixed string to all TXT and fixed syntax

d2ddb2b

properly handle () within TXT records

c701260

joshgoebel force-pushed the dns branch from 1e33800 to 4fde15f Compare October 31, 2024 22:48

support unquoted strings after TXT

757c6a2

joshgoebel force-pushed the dns branch from 4fde15f to 757c6a2 Compare October 31, 2024 22:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

edit DNS grammar #3768

edit DNS grammar #3768

Checconio commented Apr 26, 2023

joshgoebel commented Apr 27, 2023 •

edited

Loading

Checconio commented Apr 27, 2023

joshgoebel Apr 28, 2023 •

edited

Loading

joshgoebel Apr 28, 2023

joshgoebel commented Apr 28, 2023

joshgoebel left a comment •

edited

Loading

Checconio commented Apr 28, 2023

joshgoebel commented Apr 29, 2023

Checconio commented Apr 30, 2023

Checconio commented May 7, 2023

Checconio commented May 24, 2023

joshgoebel commented May 25, 2023

Checconio left a comment

Checconio commented May 26, 2023

Checconio commented Jun 23, 2023

joshgoebel commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

joshgoebel commented Oct 31, 2024

edit DNS grammar #3768

Are you sure you want to change the base?

edit DNS grammar #3768

Conversation

Checconio commented Apr 26, 2023

Changes

Checklist

joshgoebel commented Apr 27, 2023 • edited Loading

Checconio commented Apr 27, 2023

joshgoebel Apr 28, 2023 • edited Loading

Choose a reason for hiding this comment

joshgoebel Apr 28, 2023

Choose a reason for hiding this comment

joshgoebel commented Apr 28, 2023

joshgoebel left a comment • edited Loading

Choose a reason for hiding this comment

Checconio commented Apr 28, 2023

joshgoebel commented Apr 29, 2023

Checconio commented Apr 30, 2023

Checconio commented May 7, 2023

Checconio commented May 24, 2023

joshgoebel commented May 25, 2023

Checconio left a comment

Choose a reason for hiding this comment

Checconio commented May 26, 2023

Checconio commented Jun 23, 2023

joshgoebel commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

Build Size Report

4 files changed

github-actions bot commented Oct 31, 2024

Build Size Report

3 files changed

joshgoebel commented Oct 31, 2024

joshgoebel commented Apr 27, 2023 •

edited

Loading

joshgoebel Apr 28, 2023 •

edited

Loading

joshgoebel left a comment •

edited

Loading