-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate standalone role to a collection #193
Migrate standalone role to a collection #193
Conversation
54100d4
to
b562b02
Compare
87d1059
to
400166e
Compare
400166e
to
9a77afb
Compare
9a77afb
to
5e3dba4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, Norman @Normo, for migrating the role to a collection. That's already great work. 👍 I still have a couple of minor questions, though. Could you please take some time to clarify these? Thanks!
3ce5b6a
to
7bffdb6
Compare
7bffdb6
to
475c903
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into my suggestions. There is one little thing that needs some correction.
e37104b
to
b93d330
Compare
Signed-off-by: Norman Ziegner <[email protected]>
b93d330
to
ccea30a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for these improvements and the thorough implementation, Norman @Normo. I'll approve this PR now.
This PR migrates the standalone role to a collection role, which will require a new major release (v4.0.0) that will be contained in a separate release branch.
Related to #165