Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgrate nacos-sdk-go to v2 #99

Closed
wants to merge 3 commits into from

Conversation

PolarishT
Copy link
Collaborator

What type of PR is this?

feat: A new feature support nacos-sdk-go v2

What this PR does / why we need it (English/Chinese):

current hertz discovery do not support nacos-sdk-go-v2

Which issue(s) this PR fixes:

#96

@li-jin-gou
Copy link
Collaborator

可以参考 https://github.com/kitex-contrib/registry-nacos/blob/main/v2/README.md ,简略一点就可以,因为 API 是一样的。

Copy link
Collaborator

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测没过,需要修改

@@ -0,0 +1,10 @@
module github.com/hertz-contrib/registry/nacosv2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module github.com/hertz-contrib/registry/nacos/v2

@@ -0,0 +1,64 @@
// Copyright 2023 CloudWeGo Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo exmaple -> example

@li-jin-gou li-jin-gou closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants