libcnb-test: Use --trust-extra-buildpacks with pack build
#855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
edmorley/trust-extra-buildpacks
branch
2 times, most recently
from
24b5c24
to
ab15c23
Compare
To force the builder to be trusted after changes were made in Pack CLI v0.35.0 to improve security. The new flag to restore the old behaviour was only added in Pack v0.35.1, so using `libcnb-test` now requires that Pack version or newer. (Adding a version check would require calling out to Pack before every test execution, which is not worth it given that it only affects tests, and this will be a one-off transition.) Fixes #854. GUS-W-16600037.
edmorley
force-pushed
the
edmorley/trust-extra-buildpacks
branch
from
ab15c23
to
e5a524e
Compare
runesoerensen
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To force the builder to be trusted after changes were made in Pack CLI v0.35.0 to improve security:
buildpacks/pack#2228
The new flag to restore the old behaviour was only added in Pack v0.35.1, so using
libcnb-testnow requires that Pack version or newer. (Adding a version check would require calling out to Pack before every test execution, which is not worth it given that it only affects tests, and this will be a one-off transition.)Fixes #854.
GUS-W-16600037.