Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest patch version #899

Closed
wants to merge 7 commits into from
Closed

Use latest patch version #899

wants to merge 7 commits into from

Conversation

CaseyFaist
Copy link
Contributor

@CaseyFaist CaseyFaist commented Oct 29, 2019

This will allow users to specify a python major and minor branch to always use the latest patch available.

python-X.X.* is the acceptable format, where X.X are the major and minor versions.

Available versions for this tooling:

python-3.8.*
python-3.7.*
python-3.6.*
python-2.7.*

@CaseyFaist CaseyFaist marked this pull request as ready for review October 29, 2019 01:05
@CaseyFaist CaseyFaist requested a review from a team as a code owner October 29, 2019 01:05
@CaseyFaist
Copy link
Contributor Author

Hopefully will get to come back around to this next week, I'm excited about this feature 🎉

@@ -4,6 +4,21 @@ set +e
runtime-fixer runtime.txt
PYTHON_VERSION=$(cat runtime.txt)

if [[ $PYTHON_VERSION == *"*"* ]]; then
if [[ $PYTHON_VERSION == *"3.8"* ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would cause false positives - $PYTHON_VERSION == *"3.8"* will match against versions like *.3.8 or 2.3.8*

@edmorley
Copy link
Member

This is definitely something I'd like the buildpack to support (and as soon as possible!).

I've added some thoughts as to implementation approaches to #913 - closing this PR out since I'll open a new one once I start working on this :-)

@edmorley edmorley closed this Sep 22, 2020
@edmorley edmorley deleted the use-latest-branch branch September 22, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants