-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to OAI buld and platform flexibility #375
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you very much for the PR. I have suggested some changes let me know what you think
|
||
# Openairinterface nodeB Parameters | ||
# SDR USRP/LIMESDR/BLADERF | ||
SDRPLATFORM=USRP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am against adding this here you can pass it in the docker-compose file. For example, when you deploy oai_enb.yaml you can embed the variable there
SDRPLATFORM=USRP | ||
|
||
# LTE for eNB or NR for gNB | ||
RADIO=LTE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am against adding this here you can pass it in the docker-compose file. For example, when you deploy oai_enb.yaml you can embed the variable RADIO=LTE and when you use the file oai_gnb.yaml you can use RADIO=NR or something like that
|
||
ARG SDRPLATFORM | ||
|
||
RUN . ./oaienv && cd cmake_targets && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest having this logic of selecting the SDRPLATFORM and RADIO in oai_init.sh
@@ -3,8 +3,10 @@ services: | |||
oaignb: | |||
build: | |||
context: oai | |||
dockerfile: gnb_dockerfile | |||
image: docker_oai_gnb | |||
dockerfile: all_dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than building it here. I would suggest to build the image beforehand and use the image name here so that whenever you try between oaienb.yaml and oaignb.yaml the image doesnt get rebuilt
Makes running OAI easier by: