Prebuilt image enhancements #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxun Yang <[email protected]>
|
Amazing contribution.. thanks a lot. I will cherry-pick to other branches |
| @@ -27,6 +27,8 @@ | |||
| FROM ubuntu:focal | |||
|
|
|||
| ENV DEBIAN_FRONTEND=noninteractive | |||
| ENV BUILD_UHD_FROM_SOURCE=True | |||
| ENV UHD_VERSION=4.4.0.0 | |||
There was a problem hiding this comment.
Is there a possibility to not hardcode UHD version??
There was a problem hiding this comment.
Seems no, the build script requires this variable to be set.
4.4 was chosen by various official docker images, see: https://gitlab.eurecom.fr/oai/openairinterface5g/-/blob/develop/docker/Dockerfile.base.ubuntu22?ref_type=heads#L34
FlyGoat
force-pushed
the
docker-enhancements
branch
from
0e42a21
to
c650fdd
Compare
Upgrade to Ubuntu jammy so we have new limesuite and soapysdr in system repo. Use fixed v2.1 base. Build UHD from source so that TDD patch will be applied. Signed-off-by: Jiaxun Yang <[email protected]>
Signed-off-by: Jiaxun Yang <[email protected]>
FlyGoat
force-pushed
the
docker-enhancements
branch
from
c650fdd
to
c739b9d
Compare
|
@FlyGoat Hey, I will merge this once I am back from vacation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build all image variants, fix OAI image build, and provide document instructions.
Maybe it's worthy to cherry-pick those changes to all branches, so images will be built for all configurations.