Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dasdcopy: Fix error propagation in read path. #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dasdcopy: Fix error propagation in read path. #241

wants to merge 1 commit into from

Conversation

taralx
Copy link

@taralx taralx commented Dec 18, 2017

No description provided.

@taralx
Copy link
Author

taralx commented Dec 18, 2017

This was caught via -Wmisleading-indentation, which unfortunately has a bunch of misfires due to creative indentation style.

@Fish-Git
Copy link
Contributor

GitHub is preventing those without write-access to even see the merge request!   :-o

Is there a way those of us with only read-access to at least view the patch?

Or is this for some reason secret/confidential information?

<me: confused>   %-\

@Fish-Git
Copy link
Contributor

Never mind. The GitHub notification email contains links to the patch/diff.

(But still, what if you're not watching this repository and only reviewing/reading its issues? Sheesh, GitHub!)

@taralx
Copy link
Author

taralx commented Dec 18, 2017

I'm not sure why you had trouble seeing things -- the diff should be visible from the "Files changed" tab on this page.

@Fish-Git
Copy link
Contributor

the diff should be visible from the "Files changed" tab on this page.

Yes, I can see that now. Thanks.

I don't know how I was trying to access it before that it wasn't letting me. I think it was the green GitHub "This branch has no conflicts..." box with the "Only those with write access..." message that may have been confusing me:

clipboard01

Sorry for the false alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants