Skip to content

Commit

Permalink
fix: added tty option to deployment
Browse files Browse the repository at this point in the history
  • Loading branch information
henrywhitaker3 committed Feb 29, 2024
1 parent d21b341 commit bf106ab
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 1 deletion.
2 changes: 1 addition & 1 deletion chart/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.3.3
version: 1.3.4
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
Expand Down
3 changes: 3 additions & 0 deletions chart/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ spec:
{{- .Values.volumeMounts | toYaml | nindent 12 }}
{{- end }}
{{- end }}
{{- if .Values.tty }}
tty: {{ .Values.tty }}
{{- end }}
envFrom:
- configMapRef:
name: {{ include "generic.fullname" . }}
Expand Down
13 changes: 13 additions & 0 deletions chart/tests/deployment_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,19 @@ tests:
path: .spec.template.spec.containers[0].volumeMounts[0].mountPath
value: /bongo

- it: doesnt set tty if not in values
asserts:
- notExists:
path: .spec.template.spec.containers[0].tty

- it: set tty if in values
set:
tty: true
asserts:
- equal:
path: .spec.template.spec.containers[0].tty
value: true

- it: sets the probes by default
asserts:
- isNotEmpty:
Expand Down

0 comments on commit bf106ab

Please sign in to comment.