HIP: Add Exclude File Option to Helm Lint Command #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-patrucco
force-pushed
the
helm_ignore_HIP
branch
from
3a6938e
to
035b33d
Compare
Signed-off-by: Danilo Patrucco <[email protected]> Signed-off-by: danilo-patrucco <[email protected]> Signed-off-by: Danilo Patrucco <[email protected]> Signed-off-by: Danilo Patrucco <[email protected]>
danilo-patrucco
force-pushed
the
helm_ignore_HIP
branch
from
035b33d
to
1385741
Compare
danilo-patrucco
changed the title
Add Daniel Pritchett due to his participation in the feature development Signed-off-by: danilo patrucco <[email protected]>
dpritchett
added a commit
to danilo-patrucco/helm
that referenced
this pull request
Aug 15, 2024
See HIP-0019 proposal at helm/community: helm/community#353 Co-authored-by: Danilo Patrucco <[email protected]> Signed-off-by: Daniel J. Pritchett <[email protected]>
dpritchett
added a commit
to danilo-patrucco/helm
that referenced
this pull request
Aug 15, 2024
See HIP-0019 proposal at helm/community: helm/community#353 Co-authored-by: Danilo Patrucco <[email protected]> Signed-off-by: Daniel J. Pritchett <[email protected]>
dpritchett
added a commit
to danilo-patrucco/helm
that referenced
this pull request
Aug 15, 2024
See HIP-0019 proposal at helm/community: helm/community#353 Co-Authored-By: Danilo Patrucco <[email protected]> Signed-off-by: Daniel J. Pritchett <[email protected]>
dpritchett
added a commit
to danilo-patrucco/helm
that referenced
this pull request
Aug 16, 2024
See HIP-0019 proposal at helm/community: helm/community#353 Co-authored-by: Danilo Patrucco <[email protected]> Signed-off-by: Daniel J. Pritchett <[email protected]>
dpritchett
added a commit
to danilo-patrucco/helm
that referenced
this pull request
Aug 16, 2024
- adds ignorer usage to cmd/helm/lint.go - adds ignorer usage to pkg/action/lint.go and its lint_test.go See HIP-0019 proposal at helm/community: helm/community#353 Co-authored-by: Danilo Patrucco <[email protected]> Signed-off-by: Daniel J. Pritchett <[email protected]>
gjenkins8
reviewed
Sep 12, 2024
hips/hip-0019.md
Outdated
| The `.helmlintignore` file will support simple patterns to match files and directories for easy exclusion management. The `--lint-ignore-file` flag enhances this by allowing centralized management of lint exclusions in complex projects. | ||
| ## Specification | ||
| ### `.helmlintignore` File Format | ||
| The `.helmlintignore` file allows chart developers to specify filenames or glob patterns to exclude from linting. The format is straightforward, with one pattern per line, similar to `.gitignore` files. |
There was a problem hiding this comment.
I think a yaml format that can encode different types of rules/options for linting would be much more preferable than a custom / one-file-per-line format (that is limited to just that).
I also think that all/nothing for lint ignoring (per-file) is too course for the general case. Especially since many lint rules pertain (in Helm) to e.g. Chart.yaml (ref). Likely it normally would be better to exclude certain rules for Chart specific files (Chart.yaml, values.yaml (default values), etc), and paths for templates, etc. See https://github.com/helm/helm/tree/main/pkg/lint/rules for current Helm linting rules.
Also take e.g. https://yamllint.readthedocs.io/en/stable/configuration.html#configuration or https://ansible.readthedocs.io/projects/lint/configuring/#ansible-lint-configuration as inspirations/examples for what might go into a lint configuration (of course not every there will apply to Helm).
Signed-off-by: Danilo Patrucco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added HIP 0019 for the development of the lint ignore feature in helm binaries
refer to issue in helm repository #13133