Skip to content

Commit

Permalink
[fix](chore) update dcheck to avoid core during stress test (apache#2…
Browse files Browse the repository at this point in the history
  • Loading branch information
zhannngchen authored and stephen committed Dec 28, 2023
1 parent a3e8bb5 commit 88b641a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion be/src/olap/tablet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3016,7 +3016,10 @@ Status Tablet::calc_segment_delete_bitmap(RowsetSharedPtr rowset,
auto st = lookup_row_key(key, true, specified_rowsets, &loc, dummy_version.first - 1,
segment_caches, &rowset_find);
bool expected_st = st.ok() || st.is<KEY_NOT_FOUND>() || st.is<KEY_ALREADY_EXISTS>();
DCHECK(expected_st) << "unexpected error status while lookup_row_key:" << st;
// It's a defensive DCHECK, we need to exclude some common errors to avoid core-dump
// while stress test
DCHECK(expected_st || st.is<MEM_LIMIT_EXCEEDED>())
<< "unexpected error status while lookup_row_key:" << st;
if (!expected_st) {
return st;
}
Expand Down

0 comments on commit 88b641a

Please sign in to comment.