Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle case where gripper pointcloud has size 0 #84

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

hello-amal
Copy link
Collaborator

@hello-amal hello-amal commented Jul 22, 2024

Description

If the gripper's pointcloud had depth 0 while gripper depth AR were enabled , it would crash. This PR addresses that.

Testing procedure

  • Verify the fix: Before the changed code in configure_video_streams and move_to_pregrasp, add lines of code hardcoding the pointcloud size to 0 (e.g., np.zeros((0,3), dtype=np.uint16)). Launch the interface, toggle on gripper depth AR, try move-to-pregrasp, verify that the node doesn't crash.
  • Remove those lines, try the above two features, verify that they work.

Before opening a pull request

From the top-level of this repository, run:

  • pre-commit run --all-files

To merge

  • Squash & Merge

@hello-amal hello-amal changed the title Fixed bug where gripper pointcloud has size 0 Fixed bug when gripper pointcloud has size 0 Jul 22, 2024
@hello-amal hello-amal changed the title Fixed bug when gripper pointcloud has size 0 Gracefully handle case where gripper pointcloud has size 0 Jul 22, 2024
@hello-amal hello-amal merged commit 41fd0fb into master Jul 23, 2024
1 check passed
@hello-amal hello-amal deleted the amaln/gripper_depth_bugfix branch July 23, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant