Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate automated tablet placement #78

Merged
merged 10 commits into from
Jul 31, 2024
Merged

Conversation

hello-amal
Copy link
Collaborator

@hello-amal hello-amal commented Jul 18, 2024

Description

This PR integrates the automated behavior of displaying a tablet to a user into the web app.

Testing procedure

  • Pull the stretch_show_tablet repo, and pull this branch.
  • Change the tool to a tablet and run stretch_configure_tool.py.
  • Re-build your workspace.
  • ./launch_interface.sh
  • Toggle on "Show Pose", verify that it detects you when you are in Realsense camera frame and not otherwise.
  • Move to different poses (stretching, sitting, standing, legs crossed), and verify it detects you.
  • Toggle on realsense depth sensing while "Show Pose" is on, and verify both are overlaid on.
  • Verify that the "Show tablet" button appears when "Show Poses" is checked, and dissapears otherwise.
  • Uncheck "show poses". Verify the stretch_deep_perception node stops running (e.g., ros2 topic echo /body_landmarks/landmarks_3d and verify nothing publishes).
  • Drive the robot near you. Check "Show Poses." Click "Show tablet." Verify it works.
  • Repeat the above from several different base positions/orientations relative to you, and several different body postures.
  • Run "Show tablet" and then cancel it, verify that works.
  • Repeat the above, canceling at each distinct joint motion.
  • Run "Show tablet" and then command a joint motion, verify it cancels.
  • Repeat the above at every distinct joint motion in "Show Tablet."
  • Re-run the performance benchmarking documented here, verify that this code doesn't hinder performance.

Before opening a pull request

From the top-level of this repository, run:

  • pre-commit run --all-files

To merge

  • Squash & Merge

@hello-amal hello-amal marked this pull request as draft July 18, 2024 21:27
@hello-amal hello-amal marked this pull request as ready for review July 27, 2024 00:17
@hello-amal hello-amal changed the title [WIP] Integrate automated tablet placement Integrate automated tablet placement Jul 29, 2024
@hello-amal
Copy link
Collaborator Author

Tested on 3053. While I didn't run all the above tests on 3053, across multiple robots the above tests have been run. Merging it in due to time constraints.

@hello-amal hello-amal merged commit e6847ec into master Jul 31, 2024
1 check passed
@hello-amal hello-amal deleted the vinitha/tablet_placement branch July 31, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants