-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service Provider Promotions again #877
base: main
Are you sure you want to change the base?
Conversation
We now get incentive fund bps and active promotions from mobile-config list incentive promotions from mobile-config client
sp_promotions needs to be written to the reward manifest. If we pull it up a level, we can uncouple service provider rewards from carrier_client and the database.
Fill out query to return all active service provider promotions
6dc0b22
to
8d519bd
Compare
8d519bd
to
4fbc63a
Compare
} | ||
|
||
#[derive(Debug, Default, Clone)] | ||
pub struct ServiceProviderPromotions(Vec<proto::ServiceProviderPromotions>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i kinda like this wrapper and also dont
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. The plural works at both levels. I was hoping someone might help with a better name for the proto, and the wrapper name would become clearer.
Proto PR :: helium/proto#424
Please scrutinize the names.
Previously
incentive_escrow_fund_bps
was stored in Solana, and written to s3.Now
incentive_escrow_fund_bps
and promotions are stored in themetadata_db
.Temporary
metadata_db
table creationI am testing with a local table until incentive programs make it into the metadata_db proper.
Using the Column mapping and Account Structure I have the following table.