Unsettled transfer sessions #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the status of a data transfer session event and store in the corresponding table
…ttlement first and last timestamp makes sense for burning because we try and do that as often as possible. But for something that may be sitting around for a long time... A settlement message will come in and try to pick up all sessions within a window (`recv_timestamp`). `inserted_at` is for us to help with debugging.
cargo fmt really does not like lots of code inside tokio::select! macros
bbalser
approved these changes
Aug 28, 2024
jeffgrunewald
approved these changes
Aug 28, 2024
| impl DataTransferSessionReq { | ||
| pub fn to_pending_proto( | ||
| self, | ||
| received_timestamp: DateTime<Utc>, |
There was a problem hiding this comment.
can this not be derived from the DataTransferSessionReport or somesuch and just make it a impl From<DataTransferSessionReport> for PendingDataTransferSessionReqV1?
There was a problem hiding this comment.
It probably could be. How different Is the DataTransferSessionIngestReportV1.received_timestamp from file_store::FileInfo.timestamp?
michaeldjeffrey
added a commit
that referenced
this pull request
Aug 30, 2024
This reverts commit e6adffc.
michaeldjeffrey
added a commit
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proto: helium/proto#415
Settling, but later
When a Data Transfer Session is unable to have it's DC burned immediately, it's considered
Pending.At a later time, settlement for those sessions will be done manually, or by an automated process to be implemented at the time of this writing.
How do we later?
Sessions pending settlement will be written to a
pending_data_transfer_sessionstable. The table will be used in manual settlement.Sessions will also be written to a
PendingDataTransferSessionV1report in s3 for auditability.