Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP 114: Service Provider Rewards #856

Closed
wants to merge 29 commits into from
Closed

HIP 114: Service Provider Rewards #856

wants to merge 29 commits into from

Commits on Sep 6, 2024

  1. Initial work on promotion rewards

    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9ec7c4b View commit details
    Browse the repository at this point in the history

  2. Fix tests, fix indexer, improve code organization

    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    448396f View commit details
    Browse the repository at this point in the history

  3. Fixes for moogey's thing

    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1985638 View commit details
    Browse the repository at this point in the history

  4. Fix ingest test

    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    21cacee View commit details
    Browse the repository at this point in the history

  5. Add unit tests

    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b427cfe View commit details
    Browse the repository at this point in the history

  6. clippy

    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    75b267f View commit details
    Browse the repository at this point in the history

  7. ...fmt

    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d0b7834 View commit details
    Browse the repository at this point in the history

  8. Don't store subscriber id as a byte array, store as uuid

    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9624208 View commit details
    Browse the repository at this point in the history

  9. Revert "Don't store subscriber id as a byte array, store as uuid" 

    This reverts commit cee65c6.
    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    19e514f View commit details
    Browse the repository at this point in the history

  10. Fixes and stuff

    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    6a12615 View commit details
    Browse the repository at this point in the history

  11. Rename verified to validated

    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d746a5c View commit details
    Browse the repository at this point in the history

  12. Fixes

    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    bc9961b View commit details
    Browse the repository at this point in the history

  13. Fix migration

    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b047474 View commit details
    Browse the repository at this point in the history

  14. Another fix

    @maplant @macpie
    maplant authored and macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3dbdb76 View commit details
    Browse the repository at this point in the history

  15. Add back some asserts

    @macpie
    macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5a1bcdb View commit details
    Browse the repository at this point in the history

  16. - Add some comments to tests 

    - Add test for unallocated_does_not_exceed_promotion
    @macpie
    macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    6fc391f View commit details
    Browse the repository at this point in the history

  17. Rename shares_per_reward to rewards_per_share

    @macpie
    macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    691c490 View commit details
    Browse the repository at this point in the history

  18. sp_rewards_when_no_promotion_shares_hip114

    @macpie
    macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f0831b4 View commit details
    Browse the repository at this point in the history

  19. Cleaning

    @macpie
    macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    efd8b43 View commit details
    Browse the repository at this point in the history

  20. Inline fun

    @macpie
    macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0f971b6 View commit details
    Browse the repository at this point in the history

  21. Refactor validate to be simpler

    @macpie
    macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    8f6d6e8 View commit details
    Browse the repository at this point in the history

  22. Fix rebase

    @macpie
    macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1a72256 View commit details
    Browse the repository at this point in the history

  23. Fix migration file name

    @macpie
    macpie committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7f049a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. do not print mobile_rewards 

    the lines are left commented because it's useful when debugging a single test.
    @michaeldjeffrey
    michaeldjeffrey committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2c541ff View commit details
    Browse the repository at this point in the history

  2. add test getter for promotion rewards

    @michaeldjeffrey
    michaeldjeffrey committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cb30d18 View commit details
    Browse the repository at this point in the history

  3. add test with seeded service provider promotions

    @michaeldjeffrey
    michaeldjeffrey committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f12954c View commit details
    Browse the repository at this point in the history

  4. fix shares column receiving wrong name and type 

    when using an agg function like sum(), if a name is not provided, the
column will be called 'sum'.

I'm not sure why, the type of the summed column with a numeric column,
which is incompatible with an int8 field that maps to a i64 in rust.
    @michaeldjeffrey
    michaeldjeffrey committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5af0374 View commit details
    Browse the repository at this point in the history

  5. add easy derives for testing

    @michaeldjeffrey
    michaeldjeffrey committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b36909e View commit details
    Browse the repository at this point in the history

  6. update helium-anchor-gen for incentive_escrow_fund_bps field

    @michaeldjeffrey
    michaeldjeffrey committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    045f0eb View commit details
    Browse the repository at this point in the history