-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Sink Client Typing #849
Commits on Aug 19, 2024
-
make file sink parts declare their type
Instead of dealing with bundles of Vec<u8> each file sink and client will be paired over any type that can be turned into bytes.
Configuration menu - View commit details
-
Copy full SHA for 420648a - Browse repository at this point
Copy the full SHA 420648aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc66e79 - Browse repository at this point
Copy the full SHA dc66e79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48f37f1 - Browse repository at this point
Copy the full SHA 48f37f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d0399a - Browse repository at this point
Copy the full SHA 8d0399aView commit details -
Configuration menu - View commit details
-
Copy full SHA for be57669 - Browse repository at this point
Copy the full SHA be57669View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91418ff - Browse repository at this point
Copy the full SHA 91418ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea033cf - Browse repository at this point
Copy the full SHA ea033cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for ada8975 - Browse repository at this point
Copy the full SHA ada8975View commit details -
Configuration menu - View commit details
-
Copy full SHA for edcb89c - Browse repository at this point
Copy the full SHA edcb89cView commit details -
Rename trait FileStoreAsBytes -> MsgBytes to follow convention for pr…
…ost traits To keep from dealing with Vec<u8> and String auto implementations for prost::Message that disallows using a file sync with anything but a prost::Message. We're going to follow the other Msg* trait conventions where we implement them only for the types we are using. This allows someone to make a file sync for whatever type they may have, and convenience for proto types we write reports about.
Configuration menu - View commit details
-
Copy full SHA for 8b1294c - Browse repository at this point
Copy the full SHA 8b1294cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 990fd46 - Browse repository at this point
Copy the full SHA 990fd46View commit details -
rename file sink trait to writer
The abstraction comes in two parts. The first we can get a file sink from a type if it implements the FileSinkWrite trait. The second is a type being able to be written to a file sink if it can be turned into bytes. This separates the convenience from the actual functionality.
Configuration menu - View commit details
-
Copy full SHA for 2b916a6 - Browse repository at this point
Copy the full SHA 2b916a6View commit details -
file sink metric from static str to String
this allows us to attach the metric name to the file type implementation, and only have to pass in the calling crate for the prefix. FileSinks are really only created once, and there are not so many of them that owning a string introduces a crazy amount of overhead.
Configuration menu - View commit details
-
Copy full SHA for 4e90746 - Browse repository at this point
Copy the full SHA 4e90746View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae81c48 - Browse repository at this point
Copy the full SHA ae81c48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02f422c - Browse repository at this point
Copy the full SHA 02f422cView commit details -
Configuration menu - View commit details
-
Copy full SHA for da58d2a - Browse repository at this point
Copy the full SHA da58d2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94c5d28 - Browse repository at this point
Copy the full SHA 94c5d28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61bd7a1 - Browse repository at this point
Copy the full SHA 61bd7a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a18218c - Browse repository at this point
Copy the full SHA a18218cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 758bb18 - Browse repository at this point
Copy the full SHA 758bb18View commit details -
move MsgBytes trait back out of FileSinkWrite
The FileSinkWrite trait is a convenience method for creating file sinks, but it should not be tied to being able to use a file sink. The only requirement for that is being able to turn your message into bytes.
Configuration menu - View commit details
-
Copy full SHA for 8fbd2f5 - Browse repository at this point
Copy the full SHA 8fbd2f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e17ed62 - Browse repository at this point
Copy the full SHA e17ed62View commit details -
Configuration menu - View commit details
-
Copy full SHA for a59351f - Browse repository at this point
Copy the full SHA a59351fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9457e98 - Browse repository at this point
Copy the full SHA 9457e98View commit details -
combine auto_commit and roll_time into 1 argument
This is a specialized helper function, every crate using it was only using these two options. We can provide the base functionality with a single option. Ideally the Builder would be updated to take some sort of enum for the commit type as it doesn't make a lot of sense to auto_commit on every write _and_ roll the file at a certain interval.
Configuration menu - View commit details
-
Copy full SHA for 5e216b6 - Browse repository at this point
Copy the full SHA 5e216b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68d9a1c - Browse repository at this point
Copy the full SHA 68d9a1cView commit details -
- include new verified mapper code - update deps - fix botched rebase conflicts
Configuration menu - View commit details
-
Copy full SHA for b5bbad4 - Browse repository at this point
Copy the full SHA b5bbad4View commit details
Commits on Aug 22, 2024
-
uncouple FileSinkWriteExt from FileType enum
Taking a static string allows FileSinkWriteExt to be implemented by users outside the oracles codebase, and starts the journey of moving away from the FileType enum.
Configuration menu - View commit details
-
Copy full SHA for a5fe861 - Browse repository at this point
Copy the full SHA a5fe861View commit details